FINERACT-2298: migrate Standing Instructions to CommandDispatcher#6034
Draft
aditinikam wants to merge 1 commit into
Draft
FINERACT-2298: migrate Standing Instructions to CommandDispatcher#6034aditinikam wants to merge 1 commit into
aditinikam wants to merge 1 commit into
Conversation
2579dd0 to
2ea71c7
Compare
avivijay19
approved these changes
Jun 25, 2026
Member
|
@aditinikam SpotBugs check is failing you can run this locally with ./gradlew spotbugsMain spotbugsTest. while we can ignore api-compatibility-check |
2ea71c7 to
a6864d8
Compare
Migrate the Standing Instructions module off the legacy
CommandWrapperBuilder -> logCommandSource -> @CommandType (JsonCommand)
write path onto the typed CommandDispatcher (CQRS) infrastructure, fully
JsonCommand-free.
- API resource now injects CommandDispatcher and dispatches typed
StandingInstruction{Create,Update,Delete}Command; keeps the
PUT ?command=update|delete contract.
- New typed StandingInstructionWriteService + command handlers do
locale-aware parsing (DateTimeFormatter), validation, account-transfer
assembly (new ID-based AccountTransferDetailAssembler overloads) and
typed AccountTransferStandingInstruction.update(...).
- Reads: StandingInstructionReadPlatformService renamed to
StandingInstructionReadService; inline read permission checks removed in
favour of declarative SecurityConfig GET matchers.
- SecurityConfig adds GET/POST/PUT matchers for /standinginstructions
(READ/CREATE/UPDATE+DELETE) so write authorization is enforced after the
logCommandSource permission check is gone.
- Removed legacy write platform service, @CommandType handlers,
StandingInstructionDataValidator, StandingInstructionAssembler, the
JsonCommand AccountTransferStandingInstruction.update, and the
CommandWrapperBuilder standing-instruction methods.
418a4a0 to
0574d00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the Standing Instructions module off the legacy CommandWrapperBuilder -> logCommandSource -> @CommandType (JsonCommand) write path onto the typed CommandDispatcher (CQRS) infrastructure, fully JsonCommand-free.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.