FINERACT-2244: migrate Floating Rates to CommandDispatcher#6038
Draft
aditinikam wants to merge 1 commit into
Draft
FINERACT-2244: migrate Floating Rates to CommandDispatcher#6038aditinikam wants to merge 1 commit into
aditinikam wants to merge 1 commit into
Conversation
Migrate the Floating Rate module write path off the legacy
CommandWrapperBuilder -> logCommandSource -> @CommandType (JsonCommand)
pipeline onto the typed CommandDispatcher (CQRS) infrastructure, fully
JsonCommand-free.
- API resource injects CommandDispatcher and dispatches typed
FloatingRate{Create,Update}Command, returning typed responses.
- New typed FloatingRateWriteService + command handlers; FloatingRate
domain createNew/update and FloatingRateDataValidator retyped to operate
on the request DTOs (locale-aware date parsing via DateTimeFormatter).
- SecurityConfig gains POST/PUT /floatingrates matchers (CREATE/UPDATE)
since the logCommandSource permission check is gone; read endpoints and
FloatingRatesReadPlatformService are left untouched.
- Removed legacy FloatingRateWritePlatformService, @CommandType handlers,
and the CommandWrapperBuilder floating-rate methods.
- fineract-rates now depends on :fineract-command.
avivijay19
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the Floating Rate module write path off the legacy CommandWrapperBuilder -> logCommandSource -> @CommandType (JsonCommand) pipeline onto the typed CommandDispatcher (CQRS) infrastructure, fully JsonCommand-free.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.