Skip to content

FINERACT-2501: Add operationIds to Savings and Loans modules to harden feign method names#6042

Open
AshharAhmadKhan wants to merge 1 commit into
apache:developfrom
AshharAhmadKhan:FINERACT-2501-savings-loans
Open

FINERACT-2501: Add operationIds to Savings and Loans modules to harden feign method names#6042
AshharAhmadKhan wants to merge 1 commit into
apache:developfrom
AshharAhmadKhan:FINERACT-2501-savings-loans

Conversation

@AshharAhmadKhan

Copy link
Copy Markdown
Contributor

JIRA: https://issues.apache.org/jira/browse/FINERACT-2501

Description

This PR is a continuation of the work started in #5597 and #5744, which addressed the instability of auto-generated Feign client method names caused by Swagger deduplication numbers shifting when new endpoints are added.

This PR covers the Savings and Loans modules, adding explicit operationId values to all endpoints that were missing them. The naming convention follows the same pattern established in the previous PRs: methodName + EntityName + DescriptionClause (for example, retrieveOneSavingsAccountCharge, handleCommandsLoanTransaction).

Files changed:

  • SavingsAccountChargesApiResource (6 operationIds added)
  • FixedDepositAccountsApiResource (1 operationId added)
  • FixedDepositAccountTransactionsApiResource (1 operationId added)
  • RecurringDepositAccountTransactionsApiResource (1 operationId added)
  • LoansApiResource (15 operationIds added)
  • LoanTransactionsApiResource (12 operationIds added)
  • LoanChargesApiResource (5 operationIds added)
  • RescheduleLoansApiResource (5 operationIds added)
  • LoanScheduleApiResource (1 operationId added)

@AshharAhmadKhan

Copy link
Copy Markdown
Contributor Author

Hey @adamsaghy the CI seems to be failing on develop too, not sure why. Could you rerun when you get a chance?

@adamsaghy

Copy link
Copy Markdown
Contributor

Hey @adamsaghy the CI seems to be failing on develop too, not sure why. Could you rerun when you get a chance?

I dont see any particular failure on develop branch (1 flaky test, but that's harmless)

@adamsaghy

Copy link
Copy Markdown
Contributor

@AshharAhmadKhan Would you give a try to rebase this PR?

@adamsaghy

Copy link
Copy Markdown
Contributor

symbol: method retrieveLoan(long,Map<String,String>) location: interface LoansApi /home/runner/work/fineract/fineract/fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanChargeAdjustmentStepDef.java:126: error: cannot find symbol () -> fineractClient.loans().retrieveLoan(loanId, Map.of("associations", "transactions"))); ^ symbol: method retrieveLoan(long,Map<String,String>) location: interface LoansApi /home/runner/work/fineract/fineract/fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanCapitalizedIncomeStepDef.java:61: error: cannot find symbol () -> fineractClient.loans().retrieveLoan(loanId, Map.of("associations", "transactions"))); ^ symbol: method retrieveLoan(long,Map<String,String>) location: interface LoansApi /home/runner/work/fineract/fineract/fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanOverrideFieldsStepDef.java:57: error: cannot find symbol () -> fineractClient.loans().retrieveLoan(loanId, Map.of("staffInSelectedOfficeOnly", "false"))); ^ symbol: method retrieveLoan(Long,Map<String,String>) location: interface LoansApi /home/runner/work/fineract/fineract/fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanOverrideFieldsStepDef.java:104: error: cannot find symbol () -> fineractClient.loans().calculateLoanScheduleOrSubmitLoanApplication(loansRequest, Map.of())); ^ symbol: method calculateLoanScheduleOrSubmitLoanApplication(PostLoansRequest,Map<Object,Object>) location: interface LoansApi 297 errors

You might have forgot to update method names in tests.

@AshharAhmadKhan AshharAhmadKhan force-pushed the FINERACT-2501-savings-loans branch from 7b81881 to 9e50522 Compare July 1, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants