Skip to content

FINERACT-2165: Migrate LoanRescheduleRequestHelper to fineract-client-feign#6045

Merged
adamsaghy merged 1 commit into
apache:developfrom
elnafateh:FINERACT-2165/migrate-loan-reschedule-request-helper
Jun 30, 2026
Merged

FINERACT-2165: Migrate LoanRescheduleRequestHelper to fineract-client-feign#6045
adamsaghy merged 1 commit into
apache:developfrom
elnafateh:FINERACT-2165/migrate-loan-reschedule-request-helper

Conversation

@elnafateh

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy

Copy link
Copy Markdown
Contributor

@elnafateh Please review the failing checks.

@elnafateh elnafateh force-pushed the FINERACT-2165/migrate-loan-reschedule-request-helper branch from f82ee8d to a6e0f9a Compare June 27, 2026 14:07
@elnafateh

Copy link
Copy Markdown
Contributor Author

@elnafateh Please review the failing checks.

@adamsaghy it's done, kindly rerun tests

@elnafateh

Copy link
Copy Markdown
Contributor Author

the failed check is confirmed pre-existing, unrelated flakiness

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy

Copy link
Copy Markdown
Contributor

@elnafateh Please rebase this PR.

@elnafateh elnafateh force-pushed the FINERACT-2165/migrate-loan-reschedule-request-helper branch from a6e0f9a to f2c1d60 Compare June 29, 2026 13:50
@elnafateh

Copy link
Copy Markdown
Contributor Author

@adamsaghy done

@elnafateh Please rebase this PR.

@elnafateh elnafateh requested a review from adamsaghy June 29, 2026 13:55
@elnafateh elnafateh force-pushed the FINERACT-2165/migrate-loan-reschedule-request-helper branch from f2c1d60 to a8206ad Compare June 29, 2026 16:21
@adamsaghy adamsaghy merged commit 3330cda into apache:develop Jun 30, 2026
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants