FINERACT-2663: Fix compiler deprecation warnings in core, security, p…#6047
FINERACT-2663: Fix compiler deprecation warnings in core, security, p…#6047Abhishek6122008 wants to merge 1 commit into
Conversation
|
@adamsaghy Sir the only failing check is PostgreSQL Tests (Shard 7 of 15), and I'm a bit confused about it, could you give some advice on what I can do from my side to avoid this check failure? |
| case DATETIME -> Timestamp.valueOf(s); | ||
| case TIME -> Time.valueOf(s); | ||
| case DATE -> new Date(s); | ||
| case DATE -> java.sql.Date.valueOf(s); |
There was a problem hiding this comment.
this is not equivalent...
There was a problem hiding this comment.
Thanks for catching this. I was only replacing it because it's deprecated, but I didn't properly realize my change was stricter about the date format than the original hence yes they're not equivalent.
I looked into it more and couldn't find anywhere this parse method is actually called. And everywhere I saw real date handling, it used the yyyy-mm-dd format.
So would you prefer I:
Make it use the yyyy-MM-dd format like the rest of the codebase, or
Just remove this unused method instead?
There was a problem hiding this comment.
I would leave it as it was for now... i recommend just undo it
There was a problem hiding this comment.
got it sir will undo it
|
@Abhishek6122008 You might want to squash your commits into just one ;) |
…rovider, investor modules
a389271 to
7dcf216
Compare
@adamsaghy Done Sir please let me know if any other changes are needed, thank you so much in taking the time to help me with this pr really appriciate it :D. |
…rovider, investor modules
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.