MINIFICPP-2857 Processors w/o relationships have incomplete manifest …#2207
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes component manifest serialization so processors that define no relationships still emit the processor-only manifest attributes (e.g., inputRequirement, isSingleThreaded, and an empty supportedRelationships array). This addresses incomplete manifest entries that were primarily impacting test processors.
Changes:
- Extend
serializeClassDescriptionwith an explicit flag to include processor-only attributes, rather than keying off whether relationships are present. - Ensure processor manifests always include
inputRequirement,isSingleThreaded, andsupportedRelationships(even when empty), while controller services do not. - Update the Ubuntu 22.04 clang ARM reference manifest to reflect the corrected output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libminifi/src/core/state/nodes/AgentInformation.cpp | Makes processor-only manifest fields unconditional for processors by adding an explicit include_processor_only_attributes switch. |
| .github/references/ubuntu_22_04_clang_arm_manifest.json | Updates the golden/reference manifest to include the now-present processor-only fields for processors that previously omitted them. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lordgamez
approved these changes
Jun 30, 2026
szaszm
reviewed
Jun 30, 2026
fgerlits
approved these changes
Jul 6, 2026
adamdebreceni
approved these changes
Jul 6, 2026
szaszm
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…entries
Luckily this only affected test processors but we should fix it nonetheless.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.