Skip to content

[core] Reuse manifest merge results on commit retry#8229

Draft
leaves12138 wants to merge 1 commit into
apache:masterfrom
leaves12138:codex/reuse-manifest-merge-on-retry
Draft

[core] Reuse manifest merge results on commit retry#8229
leaves12138 wants to merge 1 commit into
apache:masterfrom
leaves12138:codex/reuse-manifest-merge-on-retry

Conversation

@leaves12138

@leaves12138 leaves12138 commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Reuse the previous manifest merge result on commit retry when all previously merged input manifests still exist in the latest snapshot.
  • If a retry cannot reuse that merge result, skip ManifestFileMerger.merge and write the latest snapshot data manifests directly as the new base manifest list.
  • Avoid caching the skipped no-op path as a reusable merge result for later retries.
  • Always write a fresh base manifest list for the retry commit, and add retry conflict tests for contiguous, non-contiguous, missing-before, multi-retry, empty-table, and delete-order cases.

Tests

  • mvn -pl paimon-core -Pfast-build -Dtest=FileStoreCommitTest#testCommitRetryReusePreviousManifestMergeResultWhenBeforeStillExists+testCommitRetryReusePreviousManifestMergeResultWhenBeforeExistsNonContiguously+testCommitRetrySkipsManifestMergeWhenPreviousMergeCannotBeReused+testCommitRetryReusePreviousManifestMergeResultAcrossMultipleRetries+testCommitRetryFromEmptyTableWithConcurrentFirstSnapshot+testCommitRetryReusePreviousManifestMergeResultPreservesDeleteOrder test
  • mvn -pl paimon-core -Pfast-build -Dtest=FileStoreCommitTest test
  • mvn -pl paimon-core -DskipTests compile
  • git diff --check

@leaves12138 leaves12138 force-pushed the codex/reuse-manifest-merge-on-retry branch from f203d45 to 9785f48 Compare June 15, 2026 01:59
@leaves12138 leaves12138 force-pushed the codex/reuse-manifest-merge-on-retry branch from 9785f48 to 5c1550b Compare June 15, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant