[iceberg] Support ARRAY, MAP, ROW type conversions in IcebergConversions#8245
Open
weibangpeng wants to merge 1 commit into
Open
[iceberg] Support ARRAY, MAP, ROW type conversions in IcebergConversions#8245weibangpeng wants to merge 1 commit into
weibangpeng wants to merge 1 commit into
Conversation
2 tasks
JingsongLi
reviewed
Jun 16, 2026
| (Timestamp) value, ((LocalZonedTimestampType) type).getPrecision()); | ||
| case TIME_WITHOUT_TIME_ZONE: | ||
| return timeToByteBuffer((Integer) value, ((TimeType) type).getPrecision()); | ||
| case ARRAY: |
Contributor
There was a problem hiding this comment.
This writes a Paimon-private encoding into Iceberg lower/upper bounds for nested types. Iceberg's binary single-value serialization only has implementations for primitive values (Iceberg Conversions throws for list/map/struct), so an Iceberg reader that sees these bounds will try to decode them as Iceberg metadata and fail or misinterpret them. If we cannot encode these values using Iceberg's standard format, we should omit lower/upper bounds for ARRAY/MAP/ROW instead of serializing a custom round-trip format here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IcebergConversionsTest plan
IcebergConversionsComplexTypeTestwith 17 tests covering:Closes #3788