GH-3625: Compute dataSize correctly when dealing with duplicate keys#3626
Open
nastra wants to merge 1 commit into
Open
GH-3625: Compute dataSize correctly when dealing with duplicate keys#3626nastra wants to merge 1 commit into
nastra wants to merge 1 commit into
Conversation
Contributor
Author
nastra
commented
Jun 22, 2026
| } | ||
|
|
||
| @Test | ||
| public void testDuplicateKeysDifferentSizesAcrossMultipleKeys() { |
Contributor
Author
There was a problem hiding this comment.
without the fix this test would fail with java.lang.IllegalArgumentException: Invalid byte-array offset (25). length: 22
nastra
commented
Jun 22, 2026
| } | ||
|
|
||
| @Test | ||
| public void testDuplicateKeysKeptValueLarger() { |
Contributor
Author
There was a problem hiding this comment.
without the fix this test would fail with java.lang.IllegalArgumentException: Invalid byte-array offset (10). length: 10
wgtmac
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When a Variant object is built with the same key appended more than once,
VariantBuilder.endObject()deduplicates the entries and keeps the last-written value. However, the totaldataSizeof the object's value region was computed from each key's first occurrence rather than the value that was actually retained.When duplicate keys had values of different encoded sizes, this size mismatch corrupted the output:
{"a": 1, "a": "hello"}), the buffer was under-reserved, the offset width could be undersized, and the final offset entry understated the real data length. Reading the field then threwIllegalArgumentException: Invalid byte-array offsetor returned truncated data.Closes #3625
What changes are included in this PR?
Are these changes tested?
yes, added tests that reproduce the underlying issue
Are there any user-facing changes?