GH-3628: prevent NPE & unclosed releaser#3629
Open
nastra wants to merge 1 commit into
Open
Conversation
Contributor
Author
nastra
commented
Jun 22, 2026
| store.addColumn(COLUMN, newReaderWithoutPages(options)); | ||
|
|
||
| // setReleaser() is intentionally NOT called here. | ||
| store.close(); |
Contributor
Author
There was a problem hiding this comment.
having AssertJ (#3616) would make testing this a bit easier and more explicit, because we could then just say assertThatCode(store::close).doesNotThrowAnyException()
nastra
commented
Jun 22, 2026
|
|
||
| try { | ||
| store.close(); | ||
| throw new AssertionError("Expected close() to propagate the reader failure"); |
Contributor
Author
There was a problem hiding this comment.
AssertJ would also simplify testing this error condition. We would end up having assertThatThrownBy(store::close).isInstanceof(...).hasMessage(...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ColumnChunkPageReadStore.close() NPEs if setReleaser() was never called. Also it's possible that the
releaseritself isn't closed when releasing the buffers of the readers fails anywhere in the loopCloses #3628
What changes are included in this PR?
Are these changes tested?
added a test that reproduces both cases
Are there any user-facing changes?