[SPARK-57719][SQL][TESTS] Move IdentifierClauseParserSuite to the catalyst parser package#56813
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-57719][SQL][TESTS] Move IdentifierClauseParserSuite to the catalyst parser package#56813dongjoon-hyun wants to merge 1 commit into
IdentifierClauseParserSuite to the catalyst parser package#56813dongjoon-hyun wants to merge 1 commit into
Conversation
dongjoon-hyun
changed the title
IdentifierClauseParserSuite to the catalyst parser packageIdentifierClauseParserSuite to the catalyst parser package
Member
Author
|
cc @aleksandr-chernousov-db , @cloud-fan from the original PR. |
Member
Author
|
Could you review this test case PR when you have some time, @uros-b ? |
uros-b
approved these changes
Jun 26, 2026
uros-b
left a comment
uros-b
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you @dongjoon-hyun!
Member
Author
|
Thank you, @uros-b ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 26, 2026
…talyst parser package ### What changes were proposed in this pull request? This PR moves `IdentifierClauseParserSuite` to `org.apache.spark.sql.catalyst.parser` (`sql/catalyst`) so its directory and package match. ### Why are the changes needed? This file was introduced at Spark 4.1.1 by the following. - #53407 https://github.com/apache/spark/blob/688064e691a63a44075dee769eb07ceed19068f6/sql/core/src/test/scala/org/apache/spark/sql/execution/command/IdentifierClauseParserSuite.scala#L18-L18 The suite is a Catalyst-level parser test (extends `AnalysisTest`, uses `CatalystSqlParser`) with no `sql/core` dependency, but it was placed under `execution/command` while declaring the top-level `org.apache.spark.sql` package. It's weird. Moving it next to the sibling parser suites fixes the directory/package mismatch. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 Closes #56813 from dongjoon-hyun/SPARK-57719. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 1409070) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 26, 2026
…talyst parser package ### What changes were proposed in this pull request? This PR moves `IdentifierClauseParserSuite` to `org.apache.spark.sql.catalyst.parser` (`sql/catalyst`) so its directory and package match. ### Why are the changes needed? This file was introduced at Spark 4.1.1 by the following. - #53407 https://github.com/apache/spark/blob/688064e691a63a44075dee769eb07ceed19068f6/sql/core/src/test/scala/org/apache/spark/sql/execution/command/IdentifierClauseParserSuite.scala#L18-L18 The suite is a Catalyst-level parser test (extends `AnalysisTest`, uses `CatalystSqlParser`) with no `sql/core` dependency, but it was placed under `execution/command` while declaring the top-level `org.apache.spark.sql` package. It's weird. Moving it next to the sibling parser suites fixes the directory/package mismatch. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 Closes #56813 from dongjoon-hyun/SPARK-57719. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 1409070) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 26, 2026
…talyst parser package ### What changes were proposed in this pull request? This PR moves `IdentifierClauseParserSuite` to `org.apache.spark.sql.catalyst.parser` (`sql/catalyst`) so its directory and package match. ### Why are the changes needed? This file was introduced at Spark 4.1.1 by the following. - #53407 https://github.com/apache/spark/blob/688064e691a63a44075dee769eb07ceed19068f6/sql/core/src/test/scala/org/apache/spark/sql/execution/command/IdentifierClauseParserSuite.scala#L18-L18 The suite is a Catalyst-level parser test (extends `AnalysisTest`, uses `CatalystSqlParser`) with no `sql/core` dependency, but it was placed under `execution/command` while declaring the top-level `org.apache.spark.sql` package. It's weird. Moving it next to the sibling parser suites fixes the directory/package mismatch. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 Closes #56813 from dongjoon-hyun/SPARK-57719. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 1409070) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
Merged to master/4.x/4.2/4.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR moves
IdentifierClauseParserSuitetoorg.apache.spark.sql.catalyst.parser(sql/catalyst) so its directory and package match.Why are the changes needed?
This file was introduced at Spark 4.1.1 by the following.
spark/sql/core/src/test/scala/org/apache/spark/sql/execution/command/IdentifierClauseParserSuite.scala
Line 18 in 688064e
The suite is a Catalyst-level parser test (extends
AnalysisTest, usesCatalystSqlParser) with nosql/coredependency, but it was placed underexecution/commandwhile declaring the top-levelorg.apache.spark.sqlpackage. It's weird. Moving it next to the sibling parser suites fixes the directory/package mismatch.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.8