[SPARK-57720][SQL] Fix RealTimeModeAllowlist package to match its directory#56814
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-57720][SQL] Fix RealTimeModeAllowlist package to match its directory#56814dongjoon-hyun wants to merge 1 commit into
RealTimeModeAllowlist package to match its directory#56814dongjoon-hyun wants to merge 1 commit into
Conversation
Member
Author
|
cc @jerrypeng |
Member
Author
|
Could you review this PR when you have some time, @viirya ? |
viirya
approved these changes
Jun 26, 2026
Member
Author
|
Thank you, @viirya ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 26, 2026
…irectory This PR moves the `RealTimeModeAllowlist` object into the `org.apache.spark.sql.execution.streaming.runtime` package so its package declaration matches its directory location. https://github.com/apache/spark/blob/688064e691a63a44075dee769eb07ceed19068f6/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/runtime/RealTimeModeAllowlist.scala#L27 ``` - package org.apache.spark.sql.execution.streaming + package org.apache.spark.sql.execution.streaming.runtime ``` This was introduced at Apache Spark 4.1.0 via the following. - #52891 The file lives in the `runtime/` directory but declared `package org.apache.spark.sql.execution.streaming`, unlike every other file in that directory. This aligns the package with the directory for consistency. No. Pass the CIs. Generated-by: Claude Opus 4.8 Closes #56814 from dongjoon-hyun/SPARK-57720. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 08bf0e7) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit b64e2e460c39537b6772e55882fbd1d0d9975f1f) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 26, 2026
…irectory This PR moves the `RealTimeModeAllowlist` object into the `org.apache.spark.sql.execution.streaming.runtime` package so its package declaration matches its directory location. https://github.com/apache/spark/blob/688064e691a63a44075dee769eb07ceed19068f6/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/runtime/RealTimeModeAllowlist.scala#L27 ``` - package org.apache.spark.sql.execution.streaming + package org.apache.spark.sql.execution.streaming.runtime ``` This was introduced at Apache Spark 4.1.0 via the following. - #52891 The file lives in the `runtime/` directory but declared `package org.apache.spark.sql.execution.streaming`, unlike every other file in that directory. This aligns the package with the directory for consistency. No. Pass the CIs. Generated-by: Claude Opus 4.8 Closes #56814 from dongjoon-hyun/SPARK-57720. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 08bf0e7) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit b64e2e460c39537b6772e55882fbd1d0d9975f1f) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 7309da4) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 26, 2026
…irectory This PR moves the `RealTimeModeAllowlist` object into the `org.apache.spark.sql.execution.streaming.runtime` package so its package declaration matches its directory location. https://github.com/apache/spark/blob/688064e691a63a44075dee769eb07ceed19068f6/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/runtime/RealTimeModeAllowlist.scala#L27 ``` - package org.apache.spark.sql.execution.streaming + package org.apache.spark.sql.execution.streaming.runtime ``` This was introduced at Apache Spark 4.1.0 via the following. - #52891 The file lives in the `runtime/` directory but declared `package org.apache.spark.sql.execution.streaming`, unlike every other file in that directory. This aligns the package with the directory for consistency. No. Pass the CIs. Generated-by: Claude Opus 4.8 Closes #56814 from dongjoon-hyun/SPARK-57720. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 08bf0e7) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit b64e2e460c39537b6772e55882fbd1d0d9975f1f) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 7309da4) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 2b014d6) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
Merged to master/4.x/4.2/4.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR moves the
RealTimeModeAllowlistobject into theorg.apache.spark.sql.execution.streaming.runtimepackage so its package declaration matches its directory location.spark/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/runtime/RealTimeModeAllowlist.scala
Line 27 in 688064e
Why are the changes needed?
This was introduced at Apache Spark 4.1.0 via the following.
The file lives in the
runtime/directory but declaredpackage org.apache.spark.sql.execution.streaming, unlike every other file in that directory. This aligns the package with the directory for consistency.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.8