fix: Normalize query params in dataset create_items_public_url#963
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #963 +/- ##
==========================================
- Coverage 94.64% 94.62% -0.02%
==========================================
Files 58 58
Lines 5263 5244 -19
==========================================
- Hits 4981 4962 -19
Misses 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
commented
Jul 21, 2026
vdusek
left a comment
Contributor
Author
There was a problem hiding this comment.
It's discutable whether http_client._parse_params should remain private. This is its only use case so far, so I'd probably keep it private as it is, but I'm open to discussing it.
vdusek
marked this pull request as ready for review
July 21, 2026 06:55
Pijukatel
requested changes
Jul 21, 2026
Pijukatel
reviewed
Jul 21, 2026
Pijukatel
approved these changes
Jul 21, 2026
Pijukatel
left a comment
Contributor
There was a problem hiding this comment.
Ok, I mssed some tests
Contributor
Author
Also, the PR description mentions it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DatasetClient.create_items_public_url(and its async twin) passed_build_paramsoutput straight tourlencode, bypassing the_parse_paramsnormalization that the real HTTP request path applies. As a result, boolean and list query params ended up as Python reprs in the signed URL — e.g.create_items_public_url(clean=True, fields=['title', 'url'])producedclean=True&fields=%5B%27title%27%2C+%27url%27%5Dinstead ofclean=true&fields=title,url. Consumers of the shared URL then got unclean/unfiltered items or an API error.The fix routes the params through
self._http_client._parse_params(...)beforeurlencode, so the public URL matches exactly what an actual API request would send (bool→true/false, list→comma-joined,Nonedropped). Added regression tests for both the sync and async clients.✍️ Drafted by Claude Code