ADFA-4606: Improve output panel screen reader activation#1539
Open
makhlwf wants to merge 1 commit into
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
makhlwf
force-pushed
the
community/ADFA-4606-output-panel-accessibility
branch
from
July 16, 2026 23:46
3a7b77c to
364601a
Compare
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 Walkthrough
WalkthroughThe build-status panel now exposes accessibility descriptions and expand/collapse actions. Actions invoke existing output-panel helpers, descriptions track status and sheet-state changes, setup occurs during initialization, and the delegate is cleared on detachment. New string resources provide the labels. ChangesBuild-status accessibility
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ScreenReader
participant build_status_layout
participant EditorBottomSheet
ScreenReader->>build_status_layout: Focus build-status panel
build_status_layout->>EditorBottomSheet: Perform expand or collapse action
EditorBottomSheet->>EditorBottomSheet: Expand or collapse output panel
EditorBottomSheet->>build_status_layout: Update content description
build_status_layout-->>ScreenReader: Announce updated state
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
resources/src/main/res/values/strings.xml (1)
363-364: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse the required
cd_*prefix for content descriptions.These resources are assigned to
View.contentDescription; rename them and update the Kotlin references.Proposed resource-key changes
- <string name="desc_build_status_output_panel_empty">Build status. Double tap to open output panel.</string> - <string name="desc_build_status_output_panel">Build status: %1$s. Double tap to open output panel.</string> + <string name="cd_build_status_output_panel_empty">Build status. Double tap to open output panel.</string> + <string name="cd_build_status_output_panel">Build status: %1$s. Double tap to open output panel.</string>As per coding guidelines, accessibility content descriptions must use the
cd_*convention.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@resources/src/main/res/values/strings.xml` around lines 363 - 364, Rename the content-description resources desc_build_status_output_panel_empty and desc_build_status_output_panel to use the required cd_* prefix, then update every Kotlin reference to those resource keys while preserving their existing text and behavior.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/java/com/itsaky/androidide/ui/EditorBottomSheet.kt`:
- Around line 337-367: Update the accessibility handling in the output panel
delegate’s onInitializeAccessibilityNodeInfo and performAccessibilityAction
methods so ACTION_CLICK toggles based on isOutputPanelExpanded(): collapse when
expanded and expand otherwise. Use the corresponding localized open/close label
for the node action/content description, and remove any fixed gesture
instruction from the content description while preserving explicit ACTION_EXPAND
and ACTION_COLLAPSE behavior.
---
Nitpick comments:
In `@resources/src/main/res/values/strings.xml`:
- Around line 363-364: Rename the content-description resources
desc_build_status_output_panel_empty and desc_build_status_output_panel to use
the required cd_* prefix, then update every Kotlin reference to those resource
keys while preserving their existing text and behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 13ef7e77-d9f0-4e7a-a73e-3038154190b8
📒 Files selected for processing (2)
app/src/main/java/com/itsaky/androidide/ui/EditorBottomSheet.ktresources/src/main/res/values/strings.xml
Author
|
@coderabbitai autofix |
Contributor
|
This command requires write access to the repository. Only users with write or admin permissions can trigger CodeRabbit to commit or create pull requests. |
makhlwf
force-pushed
the
community/ADFA-4606-output-panel-accessibility
branch
from
July 17, 2026 09:56
364601a to
af1a79a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1498.
Summary:
Testing: