Skip to content

ADFA-4659: Remove obsolete keystore generator plugin#1551

Merged
davidschachterADFA merged 1 commit into
stagefrom
feature/ADFA-4659-remove-keystore-generator-plugin
Jul 18, 2026
Merged

ADFA-4659: Remove obsolete keystore generator plugin#1551
davidschachterADFA merged 1 commit into
stagefrom
feature/ADFA-4659-remove-keystore-generator-plugin

Conversation

@davidschachterADFA

Copy link
Copy Markdown
Collaborator

Summary

  • Removes the keystore-generator-plugin/ directory from this repo
  • The canonical copy lives in the plugin-examples repo; this one was out of sync and not wired into the main project build (no reference in settings.gradle.kts or any build.gradle.kts)

Test plan

  • Confirm keystore-generator-plugin/ directory is gone from the repo
  • Verify the main project builds without errors (./gradlew :app:assembleV8Debug)

Closes ADFA-4659

Generated with Claude Code

The canonical copy lives in the plugin-examples repo. This standalone
directory was out of sync and not included in the main project build.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (19)
  • keystore-generator-plugin/.gitignore
  • keystore-generator-plugin/build.gradle.kts
  • keystore-generator-plugin/gradle.properties
  • keystore-generator-plugin/gradle/wrapper/gradle-wrapper.properties
  • keystore-generator-plugin/gradlew
  • keystore-generator-plugin/gradlew.bat
  • keystore-generator-plugin/proguard-rules.pro
  • keystore-generator-plugin/settings.gradle.kts
  • keystore-generator-plugin/src/main/AndroidManifest.xml
  • keystore-generator-plugin/src/main/kotlin/com/appdevforall/keygen/plugin/KeystoreGenerator.kt
  • keystore-generator-plugin/src/main/kotlin/com/appdevforall/keygen/plugin/KeystoreGeneratorPlugin.kt
  • keystore-generator-plugin/src/main/kotlin/com/appdevforall/keygen/plugin/fragments/KeystoreGeneratorFragment.kt
  • keystore-generator-plugin/src/main/res/layout/dialog_keystore_generation.xml
  • keystore-generator-plugin/src/main/res/layout/dialog_keystore_generation_simple.xml
  • keystore-generator-plugin/src/main/res/layout/fragment_keystore_generator.xml
  • keystore-generator-plugin/src/main/res/values-night/colors.xml
  • keystore-generator-plugin/src/main/res/values/colors.xml
  • keystore-generator-plugin/src/main/res/values/strings.xml
  • keystore-generator-plugin/src/main/res/values/styles.xml
⛔ Files ignored due to path filters (1)
  • keystore-generator-plugin/gradle/wrapper/gradle-wrapper.jar is excluded by !**/*.jar
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b1e74b99-d22f-4633-9693-a50a865e5206

📥 Commits

Reviewing files that changed from the base of the PR and between 8077407 and 8f741bb.

⛔ Files ignored due to path filters (1)
  • keystore-generator-plugin/gradle/wrapper/gradle-wrapper.jar is excluded by !**/*.jar
📒 Files selected for processing (19)
  • keystore-generator-plugin/.gitignore
  • keystore-generator-plugin/build.gradle.kts
  • keystore-generator-plugin/gradle.properties
  • keystore-generator-plugin/gradle/wrapper/gradle-wrapper.properties
  • keystore-generator-plugin/gradlew
  • keystore-generator-plugin/gradlew.bat
  • keystore-generator-plugin/proguard-rules.pro
  • keystore-generator-plugin/settings.gradle.kts
  • keystore-generator-plugin/src/main/AndroidManifest.xml
  • keystore-generator-plugin/src/main/kotlin/com/appdevforall/keygen/plugin/KeystoreGenerator.kt
  • keystore-generator-plugin/src/main/kotlin/com/appdevforall/keygen/plugin/KeystoreGeneratorPlugin.kt
  • keystore-generator-plugin/src/main/kotlin/com/appdevforall/keygen/plugin/fragments/KeystoreGeneratorFragment.kt
  • keystore-generator-plugin/src/main/res/layout/dialog_keystore_generation.xml
  • keystore-generator-plugin/src/main/res/layout/dialog_keystore_generation_simple.xml
  • keystore-generator-plugin/src/main/res/layout/fragment_keystore_generator.xml
  • keystore-generator-plugin/src/main/res/values-night/colors.xml
  • keystore-generator-plugin/src/main/res/values/colors.xml
  • keystore-generator-plugin/src/main/res/values/strings.xml
  • keystore-generator-plugin/src/main/res/values/styles.xml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/ADFA-4659-remove-keystore-generator-plugin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@davidschachterADFA
davidschachterADFA merged commit 6673249 into stage Jul 18, 2026
4 checks passed
@davidschachterADFA
davidschachterADFA deleted the feature/ADFA-4659-remove-keystore-generator-plugin branch July 18, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants