fix: don't double the prefix when importing prefixed relationships (#460)#704
Open
ivanauth wants to merge 1 commit into
Open
fix: don't double the prefix when importing prefixed relationships (#460)#704ivanauth wants to merge 1 commit into
ivanauth wants to merge 1 commit into
Conversation
…uthzed#460) zed import --schema=false auto-detects the schema prefix and prepended it unconditionally, so already-prefixed relationships became studio/studio/x and failed. Only prefix names that aren't already prefixed.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#461 fixed the panic, but #460 got reopened because
zed import --schema=falsethen doubled the prefix: it auto-detects the schema prefix from the server and prepended it to every relationship, even ones already prefixed. Sostudio/permissionsbecamestudio/studio/permissionsand failed with FailedPrecondition.Now it only prefixes names that aren't already prefixed. Verified against a real SpiceDB, plus unit + integration tests.
Fixes #460