fix: suppress telemetry flush logs in shutdown test#264
Merged
Conversation
The test was using mock.module() which doesn't exist in Node.js 25's test runner, causing the test to fail to load entirely. Since the logger is already in silent mode during tests (NODE_ENV=test), no mocking is needed. This resolves issue #263 where telemetry flush errors were reported even when telemetry is disabled — the error was actually from a broken test, not the application.
Owner
Author
Audit ResultsGoal Fulfillment
Spec Compliance
Task Completion
Quality Check
Verdict: All goals met. Implementation clean. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The shutdown test was using
mock.module()which doesn't exist in Node.js 25's test runner, causing the test to fail to load entirely. Since the logger is already in silent mode during tests (NODE_ENV=test), no mocking is needed. This resolves issue #263 where telemetry flush errors were reported even when telemetry is disabled — the error was actually from a broken test, not the application.Type of Change
Testing
handleShutdowndoes not throw whenflushTelemetrythrowsCoverage
Checklist
npm run lintpasses