Skip to content

TM Header Update#3844

Open
narahavi wants to merge 7 commits into
mainfrom
tmNew
Open

TM Header Update#3844
narahavi wants to merge 7 commits into
mainfrom
tmNew

Conversation

@narahavi

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes:

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment thread src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/S3TransferManager.h Outdated
Comment thread src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/UploadRequest.h Outdated
Comment thread src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/DownloadRequest.h Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/DownloadHandle.h Outdated
Comment thread src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/DownloadHandle.h Outdated
Comment thread src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/UploadResponse.h Outdated
Comment thread src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/DownloadProgressSnapshot.h Outdated
Comment thread src/aws-cpp-sdk-s3-transfer/include/aws/s3-transfer/DownloadHandle.h Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be a struct that inherits from the Aws::Client::GenericClientConfiguration? See how we do this for other clients (ex. dynamodb)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: both the uploadhandle and downloadhandle have this comment saying it's freely copyable, but they are both move-only types (not copyable)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I want you to double check is that there are no additional types in the mapping-reference json that don't already exist in the PutObjectRequest and response types (UploadResponse)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants