Conversation
There was a problem hiding this comment.
clang-tidy: https://clang.llvm.org/extra/clang-tidy/checks/readability/named-parameter.html all parameters must be named
There was a problem hiding this comment.
Should this not be a struct that inherits from the Aws::Client::GenericClientConfiguration? See how we do this for other clients (ex. dynamodb)
There was a problem hiding this comment.
nit: both the uploadhandle and downloadhandle have this comment saying it's freely copyable, but they are both move-only types (not copyable)
There was a problem hiding this comment.
One thing I want you to double check is that there are no additional types in the mapping-reference json that don't already exist in the PutObjectRequest and response types (UploadResponse)
Issue #, if available:
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.