Feat/kb endpoints api 2.3#12
Open
baraline wants to merge 18 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Refresh docs/glpi_api_contract.json from 2.2.0 (677 paths) to 2.3.0 (1237 paths). The Knowledgebase surface (10 paths, 5 component schemas) is unchanged; expansions are elsewhere (Assets, Dropdowns, Rule, Setup, Management, Assistance, Project) plus new Inventory/Notifications/Localization groups. Prep for the knowledge base endpoints feature. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Also wires the mixin into AsyncGlpiClient's mixin list (async_client.py), which the plan's Global Constraints describe as automatic via AsyncBridge but which in practice duplicates the sync mixin list and required an explicit update to keep the parity test green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Also wires the mixin into AsyncGlpiClient's mixin list (async_client.py) alongside sync_client.py, matching the KBCategoryMixin wiring. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Also wires the mixin into AsyncGlpiClient's mixin list (async_client.py) alongside sync_client.py. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…lient Also wires the mixin into AsyncGlpiClient's mixin list (async_client.py) alongside sync_client.py. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Adversarial review + live GLPI 2.3.0 validation follow-ups: - PostKBArticle: expose writable `user` (contract marks user.id rw; the spec's exclusion list never covered it). - PostKBArticleComment: expose writable `user`, drop read-only `parent`. - Strengthen the inbound HTML->Markdown assertions (were vacuous: raw HTML also contained the probe string) on article + revision Get models. - Add POST/create failure-status coverage for every KB resource. - Use @pytest.mark.usefixtures for the KB integration capability probe. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… 2.3.0 Preprod was upgraded to High-Level API 2.3.0, so the KB endpoints are now reachable. Expand the integration suite from 2 stubs to 4 tests covering every KB helper end-to-end (category/article/comment CRUD + search, and revision list/get), grounded on observed live behavior: - create responses carry an `id` key; - article content/description round-trip Markdown through GLPI HTML; - comment and revision list endpoints return flat arrays (no envelope). Also fix the user_guide example: an article's `categories` association is read-only in the contract (GLPI ignores it on write), so the example no longer implies create-time linkage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 96.88% 97.16% +0.27%
==========================================
Files 67 77 +10
Lines 2185 2397 +212
==========================================
+ Hits 2117 2329 +212
Misses 68 68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The generated contract (docs/glpi_api_contract.json) is very large and is a local development reference, not a runtime dependency (no test loads it). Remove it from version control and gitignore it; the file stays on disk for local use. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to add support for knowledge base endpoint on the REST API v2.3 of GLPI.