node-images: enable copr repo#93
Conversation
Enable the rhcontainerbot/bootc COPR repo before building the rootfs so that the composefs imageDigest fix from bootc-dev/bootc#2277 gets picked up once it merges and COPR builds resume. Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
HarshwardhanPatil07
force-pushed
the
copr-bootc-composefs-fix
branch
from
ae9cdd3 to
7ae4c0e
Compare
HarshwardhanPatil07
changed the title
| # https://github.com/bootc-dev/bink/issues/52 | ||
| ARG KERNEL_VERSION=6.19.14-300.fc44 | ||
| RUN dnf -y install 'dnf5-command(copr)' && \ | ||
| dnf -y copr enable rhcontainerbot/bootc fedora-44-x86_64 |
There was a problem hiding this comment.
I do understand why you directly add here. However, I'm reluctant to include this by default. Possibly, what we could is to add a new flavor of the disk image for composefs and this fix for the time it lands in fedora.
We could introduce a new argument that if sets will enable the copr repository and then we add a new GHA that will build the composefs disk image including bootc with this fix. This could helps us to eventually add the reverse dependencies job and test. See bootc-dev/bootc-operator#70
There was a problem hiding this comment.
Interested in your hesitation to just unconditionally add this. Yes, we're special-casing bootc here, but... bootc is special for us so it seems warranted.
Note also that this only affects the buildroot; the COPR repo is not enabled by default in the final node image built.
3 participants
Enable the copr repo before building the rootfs so that the composefs imageDigest fix from bootc-dev/bootc#2277 gets picked up once it merges and copr builds resume.