Sync common files from infra repository#83
Merged
Merged
Conversation
bootc-bot
Bot
force-pushed
the
sync-common-files
branch
3 times, most recently
from
a76040c to
42880dc
Compare
jlebon
reviewed
Jun 30, 2026
| @@ -0,0 +1,216 @@ | |||
| # Code Review Guidelines | |||
Collaborator
There was a problem hiding this comment.
Some Rust-specific guidelines in here. We should eventually look at adding Golang guidelines as well.
Synchronized from bootc-dev/infra@9b0d23f. Signed-off-by: bootc-dev Bot <bot@bootc.dev>
bootc-bot
Bot
force-pushed
the
sync-common-files
branch
from
42880dc to
8b54de7
Compare
Collaborator
|
@jlebon I think we could merge this. I added the skip of the devcontainers (bootc-dev/infra#222). The REVIEW has rust examples, but we could improve the existing one and let it resync the next time. |
jlebon
approved these changes
Jul 7, 2026
Comment on lines
+28
to
+39
| For new contributors, when using AI you SHOULD include in at least the pull | ||
| request description a rough outline of the human's level of review and | ||
| knowledge: | ||
|
|
||
| > Assisted-by: AI | ||
| > Unit tests are LLM generated. | ||
|
|
||
| > Generated-by: AI | ||
| > I am knowledgeable in this problem domain and reviewed it carefully. | ||
|
|
||
| > Generated-by: AI | ||
| > I don't know Rust|Go|... well, but I did test this and it fixed the problem. |
Collaborator
There was a problem hiding this comment.
I know this is just synced over, but I think this does need a bit more work re-reading it now. This is in AGENTS.md but it shouldn't be the agent which adds the human level of review. Probably this bit should live in CONTRIBUTING.md instead and here we tell the AI to remind the human to include any prose if applicable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by GitHub workflow (source).
This PR synchronizes common files from the infra repository.
Synchronized from bootc-dev/infra@9b0d23f.