Skip to content

Fix 'make verify' command#655

Open
erikgb wants to merge 1 commit into
cert-manager:mainfrom
erikgb:fix-verify
Open

Fix 'make verify' command#655
erikgb wants to merge 1 commit into
cert-manager:mainfrom
erikgb:fix-verify

Conversation

@erikgb

@erikgb erikgb commented Jun 21, 2026

Copy link
Copy Markdown
Member

The make verify command "escapes" the project directory when executed in the makefile-modules project. This is caused by the differences in folder structure in the source and consumer projects. Using git to resolve the project dir appears to work well.

@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jun 21, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2026
@erikgb

erikgb commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

/cc @inteon

@cert-manager-prow cert-manager-prow Bot requested a review from inteon June 21, 2026 18:45
Signed-off-by: Erik Godding Boye <egboye@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes make verify resolving the wrong project root (and potentially cd-ing outside the intended directory) by switching project root detection to Git’s notion of the repository top-level.

Changes:

  • Replace path-based root discovery in verify.sh with git rev-parse --show-toplevel.
  • Ensure verify.sh operates from the Git repository root regardless of where the script lives in the filesystem.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

set -o pipefail

projectdir="$( cd "$( dirname "${BASH_SOURCE[0]}" )/../../../.." && pwd )"
projectdir="$(git rev-parse --show-toplevel)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants