Skip to content

Add boilerplate module to project#656

Open
erikgb wants to merge 1 commit into
cert-manager:mainfrom
erikgb:boilerplate-verify
Open

Add boilerplate module to project#656
erikgb wants to merge 1 commit into
cert-manager:mainfrom
erikgb:boilerplate-verify

Conversation

@erikgb

@erikgb erikgb commented Jun 21, 2026

Copy link
Copy Markdown
Member

This adds the boilerplate module to the makefile-modules own make setup. This will ensure the boilerplate check is included in make verify, and also reduce duplication.

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jun 21, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sgtcodfish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2026
@erikgb erikgb requested a review from Copilot June 21, 2026 18:56
@erikgb

erikgb commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

/cc @inteon

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates the existing boilerplate makefile-module into this repository’s top-level Makefile, so that boilerplate/license header verification is included in the standard make verify flow and the repo no longer duplicates the target definition locally.

Changes:

  • Include modules/boilerplate/00_mod.mk and modules/boilerplate/01_mod.mk in the root Makefile.
  • Remove the locally defined verify-boilerplate target from the root Makefile (now provided by the module).
  • Document the boilerplate module in the list of modules used by this repo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants