Skip to content

Fix broken link in type docs#126

Open
erikgb wants to merge 1 commit into
cert-manager:masterfrom
erikgb:fix-broken-link
Open

Fix broken link in type docs#126
erikgb wants to merge 1 commit into
cert-manager:masterfrom
erikgb:fix-broken-link

Conversation

@erikgb

@erikgb erikgb commented Jun 21, 2026

Copy link
Copy Markdown
Member

The current link is returning 404. Reported by Max Roby on Slack: https://kubernetes.slack.com/archives/CDEQJ0Q8M/p1782042111235629

@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jun 21, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wallrj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2026
@erikgb erikgb force-pushed the fix-broken-link branch from a234d4a to 429b468 Compare June 21, 2026 12:26
@erikgb erikgb requested a review from Copilot June 21, 2026 12:26
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb erikgb force-pushed the fix-broken-link branch from 429b468 to d0d36ed Compare June 21, 2026 12:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the customDNSProviderSolver type documentation to replace a broken interface reference with a working pkg.go.dev link, and adds a compile-time assertion to ensure the solver continues to satisfy the webhook.Solver interface.

Changes:

  • Update customDNSProviderSolver docs to reference webhook.Solver via pkg.go.dev instead of a broken link.
  • Add a compile-time interface implementation assertion (var _ webhook.Solver = ...) and the corresponding import.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread main.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants