Fix broken link in type docs#126
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the customDNSProviderSolver type documentation to replace a broken interface reference with a working pkg.go.dev link, and adds a compile-time assertion to ensure the solver continues to satisfy the webhook.Solver interface.
Changes:
- Update
customDNSProviderSolverdocs to referencewebhook.Solvervia pkg.go.dev instead of a broken link. - Add a compile-time interface implementation assertion (
var _ webhook.Solver = ...) and the corresponding import.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The current link is returning 404. Reported by Max Roby on Slack: https://kubernetes.slack.com/archives/CDEQJ0Q8M/p1782042111235629