fix(setups): rename confirm param to paymentMethodName per spec#618
Merged
armando-rodriguez-cko merged 1 commit intoJul 16, 2026
Merged
Conversation
The confirm endpoint path parameter is payment_method_name (the name of the payment method to process with, e.g. tabby, klarna, card), not an option id. Rename the misleadingly-named paymentMethodOptionId argument to paymentMethodName across the client interface, implementation, and tests.
|
robert-goheen-cko
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The confirm endpoint path parameter is
payment_method_name— the name of the payment method to process the payment with (for example,tabby,klarna,card) — not an option id. TheconfirmPaymentSetupclient method named this argumentpaymentMethodOptionId, which misleads integrators into passing an id instead of a method name.Change
Rename the
paymentMethodOptionIdargument topaymentMethodNameacross the client interface, implementation, and tests, and update the doc comments with the spec's examples. The value is appended to the request path, so behaviour is unchanged — this is a naming/clarity fix.Follow-up to #616, which aligned
PaymentSetupsConfirmResponsewith thePaymentSetupschema.Verification
./gradlew compileJava compileTestJava— passes.