-
Notifications
You must be signed in to change notification settings - Fork 454
feat(electron): add passkey support #8850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeremy-clerk
wants to merge
23
commits into
jw/electron-package-scaffold
Choose a base branch
from
jw/electron-sdk-passkey-support
base: jw/electron-package-scaffold
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
32551d2
feat(electron): scaffold initial @clerk/electron package
jeremy-clerk 61ce4b0
chore(electron): Add initial main and preload scripts (#8785)
wobsoriano 83a4616
feat(electron): harden token storage encryption (#8791)
jeremy-clerk 73f716c
fix(electron): resolve storage type errors (#8792)
jeremy-clerk 48a5484
feat(electron): scaffold initial @clerk/electron package
jeremy-clerk 61ccd5d
chore(electron): Add initial main and preload scripts (#8785)
wobsoriano 1c22410
feat(electron): harden token storage encryption (#8791)
jeremy-clerk 74eb5c3
fix(electron): resolve storage type errors (#8792)
jeremy-clerk 1b938fa
feat(electron): Add initial React integration export (#8806)
wobsoriano 6c75c4e
feat(electron): add passkey support
jeremy-clerk cbb1530
docs(electron): document passkey setup
jeremy-clerk 9163b18
Merge remote-tracking branch 'origin/jw/electron-package-scaffold' in…
jeremy-clerk 1c0d40c
chore: Add custom renderer origin support (#8816)
wobsoriano abef47c
chore: dedupe
wobsoriano 3ae7b6b
Merge remote-tracking branch 'origin/jw/electron-package-scaffold' in…
jeremy-clerk 56af1b0
feat(electron): add passkey support
jeremy-clerk 5fadc7a
chore(repo): restore mosaic architecture docs
jeremy-clerk 288e7b3
feat(electron): Report SDK version to FAPI via query param (#8847)
jeremy-clerk 1aa8700
Merge remote-tracking branch 'origin/jw/electron-package-scaffold' in…
jeremy-clerk 7688b66
chore(electron): update lockfile
jeremy-clerk e1c121c
fix(electron): support dev loopback passkeys
jeremy-clerk 9006905
Merge origin/jw/electron-package-scaffold
jeremy-clerk a64c534
chore(electron): note temporary sdk version opt-out
jeremy-clerk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| name: Electron Passkeys Native Build | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| paths: | ||
| - 'packages/electron-passkeys/**' | ||
| - '.github/workflows/electron-passkeys.yml' | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build ${{ matrix.settings.target }} | ||
| runs-on: ${{ matrix.settings.host }} | ||
| timeout-minutes: 30 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| settings: | ||
| - host: macos-14 | ||
| target: aarch64-apple-darwin | ||
| - host: macos-14 | ||
| target: x86_64-apple-darwin | ||
| - host: windows-latest | ||
| target: x86_64-pc-windows-msvc | ||
| - host: windows-latest | ||
| target: aarch64-pc-windows-msvc | ||
| defaults: | ||
| run: | ||
| working-directory: packages/electron-passkeys | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
|
|
||
| - uses: pnpm/action-setup@v4 | ||
|
|
||
| - uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
| targets: ${{ matrix.settings.target }} | ||
|
|
||
| - uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| workspaces: packages/electron-passkeys | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile --ignore-scripts | ||
| working-directory: . | ||
|
|
||
| - name: Build native module | ||
| run: pnpm build --target ${{ matrix.settings.target }} | ||
|
|
||
| - name: Smoke test (host-native targets only) | ||
| if: matrix.settings.target == 'aarch64-apple-darwin' || matrix.settings.target == 'x86_64-pc-windows-msvc' | ||
| run: node -e "const m = require('./index.js'); console.log('isAvailable:', m.isAvailable(), 'capabilities:', JSON.stringify(m.capabilities())); if (!m.isAvailable()) throw new Error('the loader did not find the freshly built native binary');" | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: bindings-${{ matrix.settings.target }} | ||
| path: packages/electron-passkeys/electron-passkeys.*.node | ||
| if-no-files-found: error | ||
|
|
||
| package: | ||
| name: Assemble platform packages | ||
| needs: build | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| defaults: | ||
| run: | ||
| working-directory: packages/electron-passkeys | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
|
|
||
| - uses: pnpm/action-setup@v4 | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile --ignore-scripts | ||
| working-directory: . | ||
|
|
||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| path: packages/electron-passkeys/artifacts | ||
|
|
||
| - name: Move binaries into per-platform npm packages | ||
| run: pnpm artifacts | ||
|
|
||
| - name: Verify every platform package contains its binary | ||
| run: | | ||
| for dir in npm/*/; do | ||
| count=$(find "$dir" -name '*.node' | wc -l) | ||
| if [ "$count" -ne 1 ]; then | ||
| echo "::error::$dir is missing its .node binary — publishing it would ship an empty package" | ||
| exit 1 | ||
| fi | ||
| (cd "$dir" && npm pack --dry-run) | ||
| done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| target/ | ||
| *.node | ||
| artifacts/ | ||
| # napi-generated type defs for the raw native binding (the public surface is | ||
| # the hand-written index.js/index.d.ts loader) | ||
| native.d.ts |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saved as .template so we don't run this action yet