Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,13 @@ integration-selfcontained: build install-test-deps

integration-tests: build integration-cleanup integration-isolated integration-push integration-global integration-selfcontained ## Run all isolated, push, selfcontained, and global integration tests

integration-tests-ci-client-creds: build integration-cleanup integration-push integration-global integration-selfcontained
integration-tests-ci-client-creds: build install-test-deps integration-cleanup
$(ginkgo_int) -nodes $(NODES) -flake-attempts $(FLAKE_ATTEMPTS) \
integration/v7/push
$(ginkgo_int) -flake-attempts $(FLAKE_ATTEMPTS) \
integration/shared/global integration/v7/global
$(ginkgo_int) -nodes $(NODES) -flake-attempts $(FLAKE_ATTEMPTS) \
integration/v7/selfcontained

i: integration-tests-full
integration-full-tests: integration-tests-full
Expand Down
3 changes: 3 additions & 0 deletions actor/versioncheck/minimum_version_check.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ func IsMinimumAPIVersionMet(current string, minimum string) (bool, error) {
if minimum == "" {
return true, nil
}
if current == "" {
return false, nil
}

currentSemver, err := semver.Make(current)
if err != nil {
Expand Down
11 changes: 11 additions & 0 deletions actor/versioncheck/minimum_version_check_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,17 @@ var _ = Describe("IsMinimumAPIVersionMet", func() {
})
})

Context("current version is empty", func() {
BeforeEach(func() {
currentVersion = ""
})

It("returns false with no errors", func() {
Expect(minAPIVersionMet).To(Equal(false))
Expect(executeErr).ToNot(HaveOccurred())
})
})

Context("current version is less than min", func() {
BeforeEach(func() {
currentVersion = "3.22.0"
Expand Down
Loading