Regenerate counterfeiter fakes with v6.12.2#3799
Open
rkoster wants to merge 1 commit into
Open
Conversation
Runs go generate ./... to bring all generated fakes in sync with the counterfeiter version pinned in go.mod (v6.12.2). The main visible change is that the generated Invocations() method no longer emits per-field RLock/RUnlock calls, which is the output of the newer counterfeiter version.
jcvrabo
approved these changes
Jun 17, 2026
jcvrabo
left a comment
jcvrabo
left a comment
Member
There was a problem hiding this comment.
This looks good to me, basically doing what it states (removal of the extra locks for the invocations method)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go generate ./...to bring all generated fakes in sync with the counterfeiter version pinned ingo.mod(v6.12.2)Invocations()no longer emits per-fieldRLock/RUnlockcalls — this is the output of the newer counterfeiter versionWhy
The fakes in
mainwere generated with an older version of counterfeiter. This causes unrelated fake changes to show up in feature PRs that happened to rungo generate. This PR cleans upmainso future PRs only show fakes changes that are actually relevant to their interface changes.