Feat/Add pg_ivm Extension Support#49
Conversation
|
Hi @shusaan, thanks for your contribution. Would you be so kind to submit again your PR, by following the instructions we have placed in this document? https://github.com/cloudnative-pg/postgres-extensions-containers/blob/main/BUILD.md Thank you! |
|
Hi @shusaan, sorry to be a pain, but we have applied many changes lately to the framework and I believe we have completed all the work. I even wrote a guide on how to add a new extension. Do you mind rebasing your work on the current main and pushing your PR again? thanks. |
NiccoloFei
force-pushed
the
feat/add-pg_vim-extension
branch
3 times, most recently
from
fc78301 to
9c3a9a2
Compare
NiccoloFei
force-pushed
the
feat/add-pg_vim-extension
branch
from
11f91fb to
78ae5fa
Compare
- Add pg_ivm Dockerfile with multi-stage build - Create pg_ivm README with usage instructions for CloudNativePG clusters - Add pg_ivm metadata.hcl with version configuration for PostgreSQL 18 - Update main README.md to include pg_ivm in the extensions table Signed-off-by: Husn E Rabbi <shussan@gmail.com>
Signed-off-by: Husn E Rabbi <shussan@gmail.com>
Signed-off-by: Husn E Rabbi <shussan@gmail.com>
Signed-off-by: Husn E Rabbi <shussan@gmail.com>
Signed-off-by: Husn E Rabbi <shussan@gmail.com>
Fixed the Dockerfile to: - Install the exact EXT_VERSION submitted - Adjust the pg_ivm licenses path - Copy the entire lib/bitcode directory Added newly introduced fields to metadata.hcl and adjusted the structure to comply with the new versions format. Added missing renovate entries in pg_ivm/README.md Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Comply with conventions adopted when onboarding other extensions that contain underscores, such as pg_crash. Rename the extension's main folder in this project to `pg-ivm`, as well as `metadata.name` and `metadata.image_name`. As a result, the container image will be `ghcr.io/cloudnative-pg/pg-ivm`. It remains possible to use `pg_ivm` as a name when defining the extension's name in the Cluster's stanza. Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
gbartolini
force-pushed
the
feat/add-pg_vim-extension
branch
from
78ae5fa to
477fa45
Compare
Signed-off-by: Husn E Rabbi <shussan@gmail.com>
|
@gbartolini Would you please check this PR |
|
It needs a bit of documentation regarding |
| secretKeyRef: | ||
| name: (join('-', [$values.name, 'app'])) | ||
| key: uri | ||
| image: alpine/psql:latest |
There was a problem hiding this comment.
| image: alpine/psql:latest | |
| # renovate: datasource=docker depName=alpine/psql versioning=docker | |
| image: alpine/psql:18.4@sha256:cc22f42223f238b753c548d4cce95ced71951dac095882d1a569c49bef372707``` |
| | :--- | :--- | :--- | :--- | | ||
| | **[pgAudit](pgaudit)** | PostgreSQL audit extension | [github.com/pgaudit/pgaudit](https://github.com/pgaudit/pgaudit) | CNPG maintainers | | ||
| | **[pg_crash](pg-crash)** | **Disruptive** fault injection and chaos engineering extension | [github.com/cybertec-postgresql/pg_crash](https://github.com/cybertec-postgresql/pg_crash) | CNPG maintainers | | ||
| | **[pg_ivm](pg_ivm)** | Incremental View Maintenance for PostgreSQL | [github.com/sraoss/pg_ivm](https://github.com/sraoss/pg_ivm) | |
There was a problem hiding this comment.
| | **[pg_ivm](pg_ivm)** | Incremental View Maintenance for PostgreSQL | [github.com/sraoss/pg_ivm](https://github.com/sraoss/pg_ivm) | | |
| | **[pg_ivm](pg-ivm)** | Incremental View Maintenance for PostgreSQL | [github.com/sraoss/pg_ivm](https://github.com/sraoss/pg_ivm) | |
| # Share | ||
| COPY --from=builder /usr/share/postgresql/${PG_MAJOR}/extension/pg_ivm* /share/extension/ | ||
|
|
||
| USER 65532:65532 No newline at end of file |
There was a problem hiding this comment.
Can you add a new line here?
|
@shusaan the PR description says:
But the implementation is installing the package from pgdg. Could you update the PR description accordingly |
6 participants
Add pg_ivm Extension Support
Closes #59
Description
This PR adds support for the pg_ivm (Incremental View Maintenance) extension to the CloudNativePG postgres-extensions-containers repository.
Dependencies
The upstream CloudNativePG operator currently has a bug where PostgreSQL extension names containing underscores like
pg_ivmfail to create clusters. This PR can be merged once that issue is resolved.Task #42
Changes
New Files
pg_ivm/Dockerfile- Multi-stage build that compiles pg_ivm from sourcepg_ivm/metadata.hcl- Extension metadata and version configurationpg_ivm/README.md- Usage documentation and examplesModified Files
.github/workflows/bake.yml- Added pg_ivm to CI/CD workflowImplementation Details
Since pg_ivm is not available as a PGDG package, this implementation: