feat: add RSVP close time to workshops#2691
Open
mroderick wants to merge 5 commits into
Open
Conversation
mroderick
force-pushed
the
feature/rsvp-close-time-clean
branch
3 times, most recently
from
e07a43f to
6e34a20
Compare
The rsvp_closes_at column already exists on the workshops table (migration 20150211023345, added in 84f55d0 and later renamed from rsvp_close_time). This commit adds the model layer: virtual attributes, timezone-aware getter, before_validation callback, and validation that close time is before the workshop start.
mroderick
force-pushed
the
feature/rsvp-close-time-clean
branch
from
6e34a20 to
539d9fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2687
What
Add RSVP closing date/time to workshops, mirroring the existing "Open RSVPs at" pattern. Organisers can set when RSVPs close automatically — nil means RSVPs stay open until the workshop starts.
Changes
rsvp_closes_atvirtual attrs (rsvp_close_local_date/rsvp_close_local_time) viadatetime_from_fields, timezone-aware getter, validation that close time is before workshop startWorkshopInvitationController#acceptgated byrsvp_available?; admin attendance management unaffectedVerification
rsvp_closes_atnil → RSVPs stay open (current default)