Skip to content

Fix Claude-reported Base issues#559

Merged
codeforester merged 1 commit into
masterfrom
fix/553-557-20260610-claude-findings
Jun 10, 2026
Merged

Fix Claude-reported Base issues#559
codeforester merged 1 commit into
masterfrom
fix/553-557-20260610-claude-findings

Conversation

@codeforester

Copy link
Copy Markdown
Owner

Summary

  • Remove the hardcoded Rehearse the Homebrew upgrade contract for 1.0.0 #526 reference from the 1.0 Homebrew release reminder.
  • Keep basectl ci setup --format json stdout parseable while preserving setup logs on stderr.
  • Validate workspace manifest repos[].url values, document BASE_CI, and remove strict mode from the project installer template.

Validation

  • BASE_HOME="$PWD" PYTHONPATH="$PWD/lib/python:$PWD/cli/python" /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest cli/python/base_release/tests/test_engine.py cli/python/base_projects/tests/test_workspace_manifest.py -q
  • BASE_HOME="$PWD" bats cli/bash/commands/basectl/tests/ci.bats cli/bash/commands/basectl/tests/repo.bats
  • shellcheck -S error templates/project-install.sh cli/bash/commands/basectl/subcommands/ci.sh
  • PYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pylint --rcfile=.pylintrc cli/python/base_projects/workspace_manifest.py cli/python/base_projects/tests/test_workspace_manifest.py cli/python/base_release/engine.py cli/python/base_release/tests/test_engine.py
  • git diff --check
  • git diff --cached --check
  • env -u BASE_HOME ./bin/base-test

Closes #553
Closes #554
Closes #555
Closes #556
Closes #557

@codeforester codeforester merged commit 8c82ca0 into master Jun 10, 2026
16 checks passed
@codeforester codeforester deleted the fix/553-557-20260610-claude-findings branch June 10, 2026 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment