[ub] cleanups and feedback from initial reviewers#8739
Draft
notadragon wants to merge 124 commits into
Draft
Conversation
Contributor
Author
|
No need to merge this while work is in progress, but we can point people at this PR to review changes that have happened without re-reading the entire annex. |
Member
|
Converting this pull request to a draft. @notadragon , let me know when this is ready. |
shafik
reviewed
Feb 19, 2026
notadragon
force-pushed
the
ub-ifndr-cwgreview1
branch
from
4971020 to
b2caddb
Compare
wg21bot
added
the
needs rebase
notadragon
force-pushed
the
ub-ifndr-cwgreview1
branch
from
1872212 to
1243670
Compare
jensmaurer
reviewed
May 6, 2026
| \begin{example} | ||
| \begin{codeblock} | ||
| template <typename T> struct S; | ||
| template <> struct S<int>; // IFNDR, no definition provided. |
Member
There was a problem hiding this comment.
Is this IFNDR even if don't odr-use this specialization?
Contributor
Author
There was a problem hiding this comment.
you're right, it's not. switched to a different example.
notadragon
force-pushed
the
ub-ifndr-cwgreview1
branch
from
049e08d to
f7502a6
Compare
notadragon
force-pushed
the
ub-ifndr-cwgreview1
branch
2 times, most recently
from
cc7589f to
3b56986
Compare
…al maths functions:
* For comp_ellint_3: from "x, y" to "k, nu"
* For cyl_bessel_{i,j,k}: from "x, y" to "nu, x"
* For cyl_neumann: from "x, y" to "nu, x"
* For ellint_{1,2}: from "x, y" to "k, phi"
* For ellint_{1,2}: from "x, y, z" to "k, nu, phi"
The paper P3844R4 (LWG Motion 4) added those overloads with parameters
named differently from the names of the existing overloads, but the
latter names seem more appropriate.
Addresses editorial review committee feedback.
Fixes NB US 84-151 (C++26 CD).
The concept body introduces lm (an object of type LayoutMapping) but then uses m (an object of type M from the surrounding requirements section) in the submdspan_mapping well-formedness check.
…ng arguments (cplusplus#8995) Fixes a misapplication of P3371R5. * [linalg.algs.blas2.rank1] Add missing E in matrix_rank_1_update_c effects * [linalg.algs.blas2.symherrank1] Restore parameters in updating overload
Two integration errors in the Let clause introduced by P3663R3: - the function parameter pack is named "slices", but the Let clause references an undefined "raw_slices"; rename the parameter to match subextents (mdspan.sub.extents); - src is an mdspan but canonical_slices takes an extents object; pass src.extents() instead of src.
…g Editors' Report N5047
… "Formatting" (28.5) (cplusplus#9021)
…d up with main text body
…o be like \definition
…aningful ubdescription and ifndrdescription
notadragon
force-pushed
the
ub-ifndr-cwgreview1
branch
from
bdf0a4d to
c26a110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.