Mschaara/18977 2.8#18545
Open
mchaarawi wants to merge 2 commits into
Open
Conversation
…ode (#18291) Disable the dfuse pre-read path when timed data cache is enabled but write-back cache is disabled. The timed-cache write-through path can hit build-style workloads where files are rewritten, replaced by rename, or grown after the stat/open snapshot used to launch async pre-read. The current pre-read validation only detects a returned length mismatch, which is not sufficient to catch those cases. Keep existing timed-cache behavior otherwise, but avoid pre-read in this mode until the pre-read freshness check is strengthened. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
) free_fd() decided whether to clear a d_file_list[] slot using the object-wide ref_count instead of the slot's own references. When a struct file_obj was shared across multiple fake-fd slots (via dup() or fcntl(F_DUPFD)) and one slot's own references were exhausted while another slot still held the object, the slot was left dangling, pointing at memory that was later freed. close_all_fd() then dereferenced it at exit, corrupting the heap during teardown. Track each slot's direct fake fd open state (fd_direct_open[]) so a slot is cleared based on its own references (direct fd + dup_ref_count), while the object is freed only when the shared ref_count reaches zero. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
|
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data |
Contributor
Author
|
this is a clean cherry pick for 2 tickets that are approved to merge: i did them in 1 PR to avoid running all the dfuse feature tests twice since they take a long time. |
mchaarawi
added
the
clean-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps for the author:
After all prior steps are complete: