DAOS-19056 pipeline: fix double-free and potential memory leaks (#18411)#18548
Merged
Conversation
Fix several resource management issues in the pipeline code paths: - Free client filter parts correctly on dfs_pipeline_create/destroy error paths - Keep SGL iov cleanup consistent when kds allocation fails in dfs_readdir_with_filter - Fix the server-side pipeline handler to release bulk reply buffers and SGL iov buffers according to ownership, avoiding double-free when data is transferred via RDMA bulk Also stop returning a positive value from enum_pack_cb to terminate dkey iteration (use VOS_ITER_CB_EXIT instead), and suppress misleading DER_UNKNOWN debug logs for non-error return codes. Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
wangshilong
added
the
clean-cherry-pick
|
Ticket title is 'Potential crash using DAOS pipeline ' |
knard38
approved these changes
Jun 26, 2026
mchaarawi
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix several resource management issues in the pipeline code paths:
Also stop returning a positive value from enum_pack_cb to terminate dkey iteration (use VOS_ITER_CB_EXIT instead), and suppress misleading DER_UNKNOWN debug logs for non-error return codes.
Steps for the author:
After all prior steps are complete: