DAOS-19102 test: Stabilize NLT memcheck testing of Go binaries (#18454)#18552
Draft
mjmac wants to merge 1 commit into
Draft
DAOS-19102 test: Stabilize NLT memcheck testing of Go binaries (#18454)#18552mjmac wants to merge 1 commit into
mjmac wants to merge 1 commit into
Conversation
Go 1.25+ includes a new valgrind build tag which instruments the Go runtime in a way that valgrind can comprehend. Instead of fighting a constantly losing battle with valgrind, let's work with it and ditch the unstable suppressions that need to be updated for every release of the Go toolchain. This commit introduces scons and Jenkinsfile changes to enable this build mode for NLT, but keeps the -race build for normal non-release testing. Additionally: By default, NLT runs each test once. Add a --repeat N flag to allow for multiple iterations to really soak a change. Add a --failfast flag to allow the loop to be broken if any iteration fails; otherwise the loop will keep going until the requested number of loops has completed. New test pragmas: * NLT-repeat: N * NLT-repeat-failfast: true Signed-off-by: Michael MacDonald <github@macdonald.cx>
|
Ticket title is 'Make Go suppressions stable across toolchain versions' |
Collaborator
|
Test stage Build on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18552/1/execution/node/313/log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.25+ includes a new valgrind build tag which instruments the
Go runtime in a way that valgrind can comprehend. Instead of
fighting a constantly losing battle with valgrind, let's work
with it and ditch the unstable suppressions that need to be updated
for every release of the Go toolchain.
This commit introduces scons and Jenkinsfile changes to enable this
build mode for NLT, but keeps the -race build for normal non-release
testing.
Additionally:
By default, NLT runs each test once. Add a --repeat N flag to
allow for multiple iterations to really soak a change. Add a
--failfast flag to allow the loop to be broken if any iteration
fails; otherwise the loop will keep going until the requested
number of loops has completed.
New test pragmas:
Signed-off-by: Michael MacDonald github@macdonald.cx