Default to direct deployment engine for new deployments#5468
Open
denik wants to merge 6 commits into
Open
Conversation
The direct deployment engine is now Generally Available. Switch the default engine for new deployments from terraform to direct. Existing deployments are unaffected: their engine is read from recorded state, and the default only applies when no state and no explicit engine (config or DATABRICKS_BUNDLE_ENGINE) is set. Update docs/direct.md status to GA and add a Notable Changes entry. Add an acceptance test that deploys with the engine unset and no state, asserting the direct engine is used (via the request User-Agent). Co-authored-by: Isaac
Direct is now the default for new bundles, so reframe the section around opting out to Terraform rather than opting in to direct. Co-authored-by: Isaac
Contributor
Approval status: pending
|
Set EnvMatrix.DATABRICKS_BUNDLE_ENGINE = [] so the env var is left unset and the test runs a single time, instead of unsetting it in the script and running two identical per-engine variants. Co-authored-by: Isaac
Collaborator
|
Commit: 0364dc6
24 interesting tests: 15 SKIP, 7 KNOWN, 2 flaky
Top 28 slowest tests (at least 2 minutes):
|
Deploying a fresh, never-migrated target with the engine unset now defaults to direct instead of terraform. Update the migrate/basic output and reword the section title accordingly. Co-authored-by: Isaac
Keep the "different target, still on terraform" scenario intact by deploying the prod target explicitly with terraform, instead of relying on the (now direct) default. The subsequent debug states reads terraform from the existing state, as before. Co-authored-by: Isaac
This runtime lock file was accidentally committed; it fails the whitespace check (no trailing newline) and is regenerated locally. Untrack it and add it to .gitignore alongside the other .claude runtime files. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The direct deployment engine is now Generally Available. This switches the default engine for new deployments from
terraformtodirect.Existing deployments are unaffected: the engine is read from recorded state, and the new default only applies when there is no state and no explicit engine set (neither
bundle.engineconfig norDATABRICKS_BUNDLE_ENGINE).To opt out of the direct engine, set
engine: terraformunderbundleindatabricks.yml, or setDATABRICKS_BUNDLE_ENGINE=terraform.Changes
bundle/config/engine/engine.go:Defaultchanged fromEngineTerraformtoEngineDirect.docs/direct.md: status updated from Public Preview to Generally Available (GA).NEXT_CHANGELOG.md: added a Notable Changes entry with the opt-out path and a link to the migration docs.acceptance/bundle/state/engine_default/: new acceptance test that deploys with the engine unset and no existing state, asserting the direct engine is used (via the request User-Agent).Testing
bundle/config/...,bundle/statemgmt/...,bundle/phases/...,cmd/bundle/...pass.This pull request and its description were written by Isaac.