chore(sea): bump KERNEL_REV to kernel main (#144 merged)#429
Open
msrathore-db wants to merge 1 commit into
Open
chore(sea): bump KERNEL_REV to kernel main (#144 merged)#429msrathore-db wants to merge 1 commit into
msrathore-db wants to merge 1 commit into
Conversation
Point the SEA napi binding at databricks-sql-kernel main HEAD
9c2e2378 ("SEA parity batch: metadata PK/FK reshape + retry/backoff
kwargs + DNS fast-fail", kernel #144), up from the stale 80b68e1e.
Regenerated native/sea/index.d.ts from the bumped kernel surface
(the only committed binding artifact that changed; the .node binary
is gitignored and rebuilt by CI). New surface from #144:
- ConnectionOptions: retryMinWaitSecs / retryMaxWaitSecs /
retryMaxAttempts / retryOverallTimeoutSecs (retry/backoff knobs,
mirroring the pyo3 retry_* kwargs).
- AsyncStatement: numModifiedRows() / displayMessage() /
diagnosticInfo() / errorDetailsJson() (rich status accessors).
All additions are additive/optional — no removals. Verified:
`npm run build:native` against a kernel checkout at 9c2e2378 builds
cleanly, and `tsc` type-checks lib/ against the regenerated binding.
This bump only repoints + regenerates the binding; wiring the new
options into the driver's TypeScript layer is separate follow-up.
Co-authored-by: Isaac
Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Repoint the SEA napi binding at
databricks-sql-kernelmain HEAD9c2e2378("SEA parity batch: metadata PK/FK reshape + retry/backoff kwargs + DNS fast-fail", kernel #144), up from the stale80b68e1e.Changes
KERNEL_REV:80b68e1e…→9c2e2378…native/sea/index.d.ts: regenerated from the bumped kernel surface (the only committed binding artifact that changed — the.nodebinary is gitignored and rebuilt by CI).New napi surface from #144 (all additive/optional, no removals)
ConnectionOptions:retryMinWaitSecs,retryMaxWaitSecs,retryMaxAttempts,retryOverallTimeoutSecs— retry/backoff knobs mirroring the pyo3retry_*kwargs.AsyncStatement:numModifiedRows(),displayMessage(),diagnosticInfo(),errorDetailsJson()— rich status accessors.Verification
npm run build:nativeagainst a kernel checkout at9c2e2378builds cleanly (release).tsctype-checkslib/against the regenerated binding (no errors).KERNEL_REV" check rebuilds at the pinned SHA and diffs the committedindex.d.ts/index.js.Scope
This bump only repoints + regenerates the binding. Wiring the new retry/rich-status options into the driver's TypeScript layer is separate follow-up.
This pull request and its description were written by Isaac.