Skip to content

fix: Added index to getGroupingValue #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dvmoritzschoefl wants to merge 1 commit into
base: beta
Choose a base branch
from
Open

fix: Added index to getGroupingValue #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/table-core/src/features/column-grouping/columnGroupingFeature.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export interface ColumnDef_ColumnGrouping<
/**
* Specify a value to be used for grouping rows on this column. If this option is not specified, the value derived from `accessorKey` / `accessorFn` will be used instead.
*/
getGroupingValue?: (row: TData) => any
getGroupingValue?: (row: TData, index: number) => any
}

export interface Column_ColumnGrouping<
Expand Down
1 change: 1 addition & 0 deletions packages/table-core/src/features/column-grouping/columnGroupingFeature.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ export function row_getGroupingValue<
if (row._groupingValuesCache) {
row._groupingValuesCache[columnId] = column.columnDef.getGroupingValue(
row.original,
row.index,
)
}

Expand Down