Skip to content

Fix completion crash when tables are created during refresh #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-bennet merged 2 commits into from
Jul 20, 2026
+4 −0
Merged

Fix completion crash when tables are created during refresh #1591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da5436
Fix completion crash when tables are created during refresh
shgol May 3, 2026
2531f5c
Merge branch 'main' into main
j-bennet Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ Contributors:
* Charalampos Stratakis
* Laszlo Bimba (bimlas)
* Anjanna
* Shayan Golshani (shgol)
* Tommi Kyntölä (kynde)

Creator:
Expand Down
1 change: 1 addition & 0 deletions changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Bug fixes:
* Fix trailing SQL comments preventing query submission and execution.
* ``SELECT 1; -- note`` now submits correctly in multiline mode
* ``rstrip(";")`` in ``pgexecute.py`` now handles comments after the semicolon
* Fix completion crash when tables are created during refresh.
* Suggest columns after `GROUP BY`, like `ORDER BY` already does.

4.4.0 (2025-12-24)
Expand Down
2 changes: 2 additions & 0 deletions pgcli/pgcompleter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ def extend_columns(self, column_data, kind):
has_default=has_default,
default=default,
)
metadata.setdefault(schema, {})
metadata[schema].setdefault(relname, OrderedDict())
metadata[schema][relname][colname] = column
self.all_completions.add(colname)

Expand Down
Loading