Skip to content

fix: relative symlink resolution in install script #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
V-Subhankar-infy wants to merge 1 commit into
base: main
Choose a base branch
from
+32 −1
Draft

fix: relative symlink resolution in install script #1244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ set -e
# Handle both direct execution and symlinked scenarios
if [ -L "$0" ]; then
# Follow symlink
SCRIPT_PATH="$(readlink "$0" 2>/dev/null || readlink -f "$0" 2>/dev/null || echo "$0")"
SCRIPT_PATH="$(readlink -f "$0" 2>/dev/null || readlink "$0" 2>/dev/null || echo "$0")"
else
SCRIPT_PATH="$0"
fi
Expand Down
31 changes: 31 additions & 0 deletions scripts/install.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,37 @@ test_wrapper_via_symlink() {
teardown
}

# ── Tests: wrapper via relative symlink from different directory ──

test_wrapper_via_relative_symlink() {
printf '%b\n' "${C_BOLD}Wrapper works via relative symlink from different directory${C_RESET}"
setup

prefix="$TEST_TMPDIR/devcontainers"
cli_version="0.75.0"

sh "$INSTALL_SCRIPT" --prefix "$prefix" --version "$cli_version" >/dev/null 2>&1

# Create a RELATIVE symlink in a different directory
link_dir="$TEST_TMPDIR/bin"
mkdir -p "$link_dir"

# Create relative symlink that points back to the wrapper
ln -s ../devcontainers/bin/devcontainer "$link_dir/devcontainer"
assert_symlink "$link_dir/devcontainer" "relative symlink created"

# Call from a different directory
cwd_before=$(pwd)
cd "$TEST_TMPDIR"
version_output=$("$link_dir/devcontainer" --version 2>/dev/null) && wrc=0 || wrc=$?

cd "$cwd_before"
assert_exit_code "0" "$wrc" "relative symlink works from different directory"
assert_contains "$version_output" "$cli_version" "relative symlink wrapper reports version"

teardown
}

# ── Tests: install to path with spaces ────────────────────────────

test_path_with_spaces() {
Expand Down
Loading