Adding OhMyZsh-Theme Option to common-utils feature#1564
Conversation
Co-authored-by: the78mole <7723396+the78mole@users.noreply.github.com>
Co-authored-by: the78mole <7723396+the78mole@users.noreply.github.com>
Co-authored-by: the78mole <7723396+the78mole@users.noreply.github.com>
Add ohMyZshTheme configuration option to common-utils
|
@microsoft-github-policy-service agree |
Kaniska244
left a comment
Kaniska244
left a comment
There was a problem hiding this comment.
Hi @the78mole
Thank you for the contribution. Would you kindly do a minor common-utils feature version bump for this.
|
Totally forgot that... For sure I can bump the version... |
| usermod -a -G "${extra_group}" "${USERNAME}" | ||
| done | ||
| fi | ||
|
|
There was a problem hiding this comment.
Hi @the78mole
Would you kindly provide some background/ use cases where the ADD_GROUPS functionality could be useful?
There was a problem hiding this comment.
Quite easy to explain... If you do embedded development, you usually need to map /dev into your devcontainer to access e.g. /dev/ttyUSB0 to flash your device. To access such devices, your user needs to be member of dialup group... Other devices need plugdev group membership...
|
Sorry, some commits on my main have not been intended... I'll removing it again... (in a few minutes) |
This pull request adds support for customizing the Oh My Zsh theme during installation in the
common-utilsfeature. The main changes include introducing a newohMyZshThemeoption, updating scripts to handle this option safely, and adding tests to verify theme customization.Feature: Oh My Zsh Theme Customization
ohMyZshThemeoption todevcontainer-feature.json, allowing users to specify the Oh My Zsh theme (default:devcontainers).README.mdto document the newohMyZshThemeoption and its usage.Feature: Add groups to non-root User
addGroupsoption todevcontainer-feature.json, allowing users to specify additional groups the non-root user shall belong to.README.mdto document the newaddGroupsoption and its usage.Implementation: Script Updates
install.shandmain.shto accept and use theOH_MY_ZSH_THEMEenvironment variable, defaulting todevcontainersif not specified. [1] [2]install.shandmain.shto accept and use the newADD_GROUPSenvironment variable, defaulting to no value if not specified.main.shto validate the theme name and update.zshrcaccordingly, falling back to the default if the provided name is invalid.main.shto validate the groups, creating them if not existent.Testing: Custom Theme Scenario
custom-zsh-theme.shto verify that the specified theme is applied and Oh My Zsh is installed.scenarios.jsonto include a scenario for testing custom theme installation with thefinotheme.scenarios.jsonto include a scenario for testing adding groups plugdev and dialout (usually needed for embedded development.