#1965: improve dependent installations

[AdemZarrouki]

This PR fixes #1965

Implemented changes:

• For NpmBasedCommandlet installed-version checks now call runPackageManager(request, true) which prevents npm list -g <package> --depth=0 from recursively triggering npm.install.
• npm-based tools now skip the package-manager installation step when npm is already available.
• The same was done for PipBasedCommandlet

---

Testing instructions

For the test you can use Intellij directly by running com.devonfw.tools.ide.cli.Ideasy with install <Tool> as arguments or using GraalVM and the call the created ideasy.exe with install <Tool>

1. Run the ideasy cli with install nest: you see

$ ide install nest
No CVEs found for version 11.0.21 of tool nest.
added 210 packages in 23s
39 packages are looking for funding
  run `npm fund` for details
Successfully installed nest in version 11.0.21 at C:\Users\projects\IDEasy\software\node

2. For tools that has a declared dependency on node like ng we get this:

$ ide install ng
No CVEs found for version 22.0.1 of tool ng.
No CVEs found for version v24.16.0 of tool node.
Version v24.16.0 of tool node is already installed
npm warn using --force Recommended protections disabled.

added 276 packages in 29s

68 packages are looking for funding
  run `npm fund` for details
Successfully installed ng in version 22.0.1 at C:\Users\projects\IDEasy\software\node

3. No reduandant call of node or npm should be present to the user.

---

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

• When running mvn clean test locally all tests pass and build is successful
• PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
• PR top-level comment summarizes what has been done and contains link to addressed issue(s)
• PR and issue(s) have suitable labels
• Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
• You followed all coding conventions
• You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
  with internal
• You have formulated clear instructions on how to test your contribution under "Testing instructions"

[coveralls]

Coverage Report for CI Build 27812007724

Coverage increased (+0.007%) to 71.388%

Details

• Coverage increased (+0.007%) from the base build.
• Patch coverage: No coverable lines changed in this PR.
• 2 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

2 previously-covered lines in 2 files lost coverage.

File	Lines Losing Coverage	Coverage
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java	1	78.33%
com/devonfw/tools/ide/version/VersionSegment.java	1	89.5%

---

Coverage Stats

Relevant Lines:	16276
Covered Lines:	12117
Line Coverage:	74.45%
Relevant Branches:	7284
Covered Branches:	4702
Branch Coverage:	64.55%
Branches in Coverage %:	Yes
Coverage Strength:	3.15 hits per line

---

💛 - Coveralls

[laert-ll]

I want to make sure I understand the scope correctly: the issue description gave me the impression that the fix was supposed to be on a bigger scale (using the parent install request so loops get detected on their own). So is it intentional to use the skipInstallation as a workaround or am I missing something?
Also it might be a good idea to add some tests for this as well.

Everything works well, the issue is solved in a simple way and removes the problem, thanks for your work!

[laert-ll]

Is there any particular reason why Pip doesn't override isSkipInstallation() in the same way that Npm does?

[AdemZarrouki]

because i didn't found a loop dependency that can occurs in pip context.

[AdemZarrouki]

regarding tests i will add some junit tests in NgTest and NestTest

[AdemZarrouki]

so after checking the tests again before the fix i see this

Deleting target\ide-projects\nest ...
Starting to copy src\test\resources\ide-projects\nest recursively to target\ide-projects\nest
No CVEs found for version 11.0.21 of tool nest.
Tool nest has 0 other tool(s) as dependency
Installation from <none> to nest@11.0.21.
No CVEs found for version 9.9.2 of tool npm.
Tool npm has 1 other tool(s) as dependency
Tool node not installed in C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\software\node
Tool node not installed in C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\software\node
No CVEs found for version v18.19.1 of tool node.
Tool node has 0 other tool(s) as dependency
Installation from <none> to node@v18.19.1.
Could not find version v18.19.1 so using 'default' for node/node
Resolved version v18.19.1 to version v18.19.1
Trying to download node-v18.19.1.tgz from http://localhost:57896/download/node/node/v18.19.1/node-v18.19.1.tgz
Content-Length was not provided by download from http://localhost:57896/download/node/node/v18.19.1/node-v18.19.1.tgz
No checksum found for C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\_ide\tmp\Downloads\node-v18.19.1.tgz
Extracting TAR file C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\home\Downloads\ide\default\node-v18.19.1.tgz to C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\_ide\tmp\extract-node-v18.19.1.tgz
Installed node in version v18.19.1 at C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\software\node
Installation from <none> to node@v18.19.1.
BASH_PATH environment variable was not found
A proper bash executable was found in your PATH environment variable at: C:\Program Files\Git\usr\bin\bash.exe
Running command 'C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\software\node\npm' using bash with arguments 'config' 'set' 'prefix' 'C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\software\node' ...
npm config set prefix C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\software\node
Setting npm config prefix to: C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\software\node was successful
Successfully installed node in version v18.19.1 at C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\software\node
Installation from <none> to npm@9.9.2.
Running command 'C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\software\node\npm' using bash with arguments 'install' '-gf' 'npm@9.9.2' ...
npm install -gf npm@9.9.2
Installation from <none> to npm@9.9.2.
Successfully installed npm in version 9.9.2 at C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\software\node
Running command 'C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\software\node\npm' using bash with arguments 'install' '-gf' '@nestjs/cli@11.0.21' ...
npm install -gf @nestjs/cli@11.0.21
Installation from <none> to nest@11.0.21.
Successfully installed nest in version 11.0.21 at C:\Users\projects\IDEasy\workspaces\main\IDEasy\cli\target\ide-projects\nest\project\software\node

so the loop of dependency of node and npm is not present in the tests (maybe because of the resources we are using)