docs(layout): document the mouse-override icon in the pane-header spec#154
Open
dormouse-bot wants to merge 1 commit into
Open
docs(layout): document the mouse-override icon in the pane-header spec#154dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
…ment list and tiers The pane-header spec omitted the mouse-reporting override icon from both the element list and the responsive-tier breakdown. #148 made its tier behavior concrete (hidden at the minimal tier) without updating the spec. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
a75cb98
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4cf902a8.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-layout-spec-mouse-icon.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The pane-header section of
docs/specs/layout.mdomitted the mouse-reporting override icon entirely — it was absent from both the "Elements from left to right" list and the responsive-tier breakdown.The icon has lived in the header for a while (defined in
docs/specs/mouse-and-clipboard.md), but #148 made its tier behavior concrete: it now drops at theminimaltier (showMouseIcon && tier !== 'minimal'inTerminalPaneHeader.tsx). That change updated the code without updating layout.md, leaving the placement/tier spec — which AGENTS.md designates as the source of truth for header element placement and sizing — incomplete.Changes (docs only)
docs/specs/mouse-and-clipboard.mdfor its visual states/behavior, mirroring how the bell and TODO pill point atalert.md.Verification
Cross-checked against the source: the render order in
lib/src/components/wall/TerminalPaneHeader.tsxplaces the icon between the flexible (flex-1 overflow-hidden) region and thetier === 'full'split/zoom block, gated ontier !== 'minimal'; tier thresholds (>280full,>160compact, else minimal) match theResizeObservercallback. Terminology (CursorClickIcon/SelectionSlashIcon, "Mouse icon") matchesmouse-and-clipboard.md.No regression test — this is a documentation-only change with no runtime behavior.