policy: close memoized policy filesystems#3943
Open
crazy-max wants to merge 1 commit into
Open
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes policy filesystem cleanup so a policy filesystem opened during policy loading is fully closed after use.
Here is a repro with simple test:
That happens because
loadPolicyDatadoes bothStatandReadFile, and each call resolves the memoized policy filesystem. The old close path only decremented one reference, so the opened filesystem root stayed alive on Windows.The policy path filesystem now closes all memoized filesystem references when the wrapper is closed, instead of decrementing only one reference.
Policy loading can resolve the same memoized filesystem more than once while reading a policy file. Closing only one reference can leave the underlying filesystem open, which is especially visible on Windows when temporary policy directories cannot be removed.