fix: [CI-23219]: remediate vulnerabilities in harnesssecure/github-actions#25
Open
chhawchharia wants to merge 2 commits into
Open
fix: [CI-23219]: remediate vulnerabilities in harnesssecure/github-actions#25chhawchharia wants to merge 2 commits into
chhawchharia wants to merge 2 commits into
Conversation
…tions - bump base image docker:dind -> docker:29.6.0-dind - bump nektos/act v0.2.61 -> v0.2.89 - update go.mod toolchain + key dependencies (go-git, x/crypto, x/net, etc.)
The vuln remediation raised the go.mod directive to `go 1.25.0`, but the .drone.yml build step still used `golang:1.22.7`. A 1.22 toolchain cannot cleanly build a 1.25 module (auto-toolchain download is fragile and fails under GOTOOLCHAIN=local), and it would compile the plugin binary with an outdated Go stdlib, re-introducing stdlib CVEs into the image. Pin the build image to the latest 1.25 patch (1.25.11), which also carries the stdlib fix for CVE-2025-47910. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates security vulnerabilities in
harnesssecure/github-actions:1.0(Jira CI-23219, parent epic CI-23213). Baseline scan: 296 findings (6 Critical, 59 High, 75 Medium, 30 Low).Ships from an
originbranch (not a fork) so Drone CI can access build/publish secrets. Consolidates the original remediation plus a required CI-toolchain fix that was missing from the earlier PRs.Changes
docker/Dockerfile.linux.amd64docker:dind→docker:29.6.0-dind;actv0.2.61→v0.2.89actbinarygo.modgo 1.22.7→1.25.0; dep bumps (notablygo-git/go-git/v55.13.1 → 5.19.1)go.sumgo.mod.drone.ymlgolang:1.22.7→golang:1.25.11go.modbump fixesVerification (deep-dive, no functional regressions)
Static/build:
go build ./...,go vet ./..., and the fullgo test ./...suite pass.Only three dependencies change runtime behavior; each was validated:
cloner/(go-git 5.13 → 5.19): real-network clone integration tests pass for tag, branch, and a+-special tag (the last exercises theErrReferenceNotFound→ inverse-ref retry path). API surface compiles unchanged.act0.2.61 → 0.2.89: all 10 CLI flags the plugin passes (-W,-P,--secret-file,--env-file,-b,--detect-event,--container-options,--actor,--eventpath,-v) remain supported; binary installs and runs.daemon/(docker 28 → 29 dind):dockerd29.6.0 initializes cleanly with the plugin's exact flags;DOCKER_HOST=tcp://docker:2375is identical across dind 20.10/24/27/28/29 (no client-connection regression);daemon/code is untouched by this PR.govulncheckconfirms the reachable Go-stdlib CVEs close once built withgolang:1.25.11.cmd/,utils/, andpkg/encoderdepend only on unchanged dependency versions (urfave/cli,gopkg.in/yaml.v2,joho/godotenv,buildkite/yaml,ghodss/yaml), so no behavior change is possible there.Test plan
golang:1.25.11docker:29.6.0-dind+act v0.2.89) succeeds in CIRelated
Made with Cursor