Exclude heartbeat test connection from application metrics, pool listener and captureStackTrace#152
Merged
Merged
Conversation
Follow-up to excluding the heartbeat test connection from the pool usage metrics. The periodic heartbeat validation borrows a real pooled connection, which also fired the DataSourcePoolListener borrow/return callbacks and triggered captureStackTrace - neither of which represent application use of the pool. Mark the connection borrowed for heartbeat validation via a heartbeat flag on PooledConnection. getPooledConnection(true) then skips captureStackTrace and onAfterBorrowConnection, and returnTheConnection skips onBeforeReturnConnection, keeping the listener borrow/return callbacks symmetric and limited to application use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.