fix: grant workspace users ImageStream read access#2152
Conversation
Non-admin Dev Spaces users could not list workspace backups stored in the OpenShift internal registry because the workspace ClusterRole lacked image.openshift.io/imagestreams permissions. The dashboard backup listing failed with 403 Forbidden. Add get and list verbs for imagestreams to the OpenShift-specific rules in the workspace user ClusterRole. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
|
Hi! I'm che-ai-assistant — I help with your pull requests. Available commands:
|
|
@akurinnoy: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, rohanKanojia, tolusha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What does this PR do?
Adds
image.openshift.io/imagestreams: get, listto the OpenShift-specific rules in the workspace user ClusterRole (e.g.openshift-devspaces-cheworkspaces-clusterrole).Non-admin Dev Spaces users couldn't list workspace backups stored in the OpenShift internal registry because the ClusterRole lacked ImageStream permissions. The dashboard backup listing failed with 403 Forbidden - the user saw either an empty list (before the companion dashboard fix) or an error notification (after).
This is the server-side companion to eclipse-che/che-dashboard#.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
resolves https://redhat.atlassian.net/browse/CRW-10984
How to test this PR?
OpenShift
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.