Skip to content

fix: grant workspace users ImageStream read access#2152

Open
akurinnoy wants to merge 1 commit into
mainfrom
fix/crw-10984-imagestream-rbac
Open

fix: grant workspace users ImageStream read access#2152
akurinnoy wants to merge 1 commit into
mainfrom
fix/crw-10984-imagestream-rbac

Conversation

@akurinnoy

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds image.openshift.io/imagestreams: get, list to the OpenShift-specific rules in the workspace user ClusterRole (e.g. openshift-devspaces-cheworkspaces-clusterrole).

Non-admin Dev Spaces users couldn't list workspace backups stored in the OpenShift internal registry because the ClusterRole lacked ImageStream permissions. The dashboard backup listing failed with 403 Forbidden - the user saw either an empty list (before the companion dashboard fix) or an error notification (after).

This is the server-side companion to eclipse-che/che-dashboard#.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

resolves https://redhat.atlassian.net/browse/CRW-10984

How to test this PR?

  1. Deploy the operator
  2. Ensure the DWOC has backup configured with the OpenShift internal registry:
    config:
      workspace:
        backupCronJob:
          enable: true
          oras:
            extraArgs: '--insecure'
          registry:
            path: image-registry.openshift-image-registry.svc:5000
          schedule: '*/5 * * * *'
  3. Login as a non-admin user, create a workspace
  4. Stop the workspace, wait for backup to complete
  5. Navigate to the Backups tab on the Workspaces page
  6. Verify the backup list loads without errors

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Non-admin Dev Spaces users could not list workspace backups stored
in the OpenShift internal registry because the workspace ClusterRole
lacked image.openshift.io/imagestreams permissions. The dashboard
backup listing failed with 403 Forbidden.

Add get and list verbs for imagestreams to the OpenShift-specific
rules in the workspace user ClusterRole.

Assisted-by: Claude Opus 4.6 (1M context)
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@tolusha

tolusha commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Hi! I'm che-ai-assistant — I help with your pull requests.

Available commands:

  • /che-ai-assistant generate-che-doc — Generate a documentation PR based on this PR's changes
  • /che-ai-assistant ok-pr-review — Run a comprehensive PR review (summary, code review, deep review, impact analysis)
  • /che-ai-assistant check-pr-test-failures — Analyze failing CI checks, identify root causes, and suggest fixes
  • /che-ai-assistant help — Show this help message

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown

@akurinnoy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v19-devworkspace-happy-path 5f0a41e link true /test v19-devworkspace-happy-path
ci/prow/v19-upgrade-stable-to-next 5f0a41e link true /test v19-upgrade-stable-to-next

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, rohanKanojia, tolusha

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants