Add selector specificity tests pinning cascade ordering#4091
Open
vogella wants to merge 1 commit into
Open
Conversation
Contributor
Test Results 864 files 864 suites 42m 52s ⏱️ For more details on these failures, see this check. Results for commit bb88085. ♻️ This comment has been updated with latest results. |
vogella
force-pushed
the
css-selector-specificity-tests
branch
3 times, most recently
from
da08ff4 to
2364fd1
Compare
Lock in the CSS 2.1 specificity the internal Selector AST computes (id 100, class / attribute / pseudo 10, element 1, universal 0; combinators sum, selector lists report the maximum). Cascade order depends on these values, so the replacement parser planned for Phase 3 step 2 must reproduce them.
vogella
force-pushed
the
css-selector-specificity-tests
branch
from
2364fd1 to
bb88085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests pin the CSS 2.1 specificity that the internal Selector AST computes: 100 for an id, 10 for a class, attribute or pseudo-class, 1 for an element, and 0 for the universal selector, with combinators summing their operands and a selector list reporting the maximum.
Cascade ordering depends on these values, so locking them in keeps the parser replacement planned for the next step from silently shifting selector precedence.
The change is test-only and touches no production code.
Contributes to #3980.