Ask about installing git hooks as part of ./bootstrap.py#27238
Open
sbc100 wants to merge 1 commit into
Open
Conversation
sbc100
force-pushed
the
install_hooks
branch
5 times, most recently
from
445ba73 to
18de9ae
Compare
Just like all the other actions that bookstrap performs it will only run it if the stamp file is missing, so it effectively only asks once (unless you delete the stamp in the `out/` directory).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel like these two hooks a very useful, but maybe folks don't know about them, or how to install them? This change effectively advertises the option to install to anyone who runs
./bootstrap.pyin an interactive shell.Just like all the other actions that bookstrap performs it will only run it if the stamp file is missing, so it effectively only asks once (unless you delete the stamp in the
out/directory).