Skip to content

Factor out common methods from update_***.py (NFC)#27252

Merged
aheejin merged 1 commit into
emscripten-core:mainfrom
aheejin:update_refactor
Jul 4, 2026
Merged

Factor out common methods from update_***.py (NFC)#27252
aheejin merged 1 commit into
emscripten-core:mainfrom
aheejin:update_refactor

Conversation

@aheejin

@aheejin aheejin commented Jul 3, 2026

Copy link
Copy Markdown
Member

No description provided.

Comment thread system/lib/update_common.py
@sbc100

sbc100 commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Another couple of features I though we could add to these scripts:

  1. Confirm the that the source directory is clean (no changes) before copying its contents
  2. Automatically update the readme with the commit/branch we are syncing too?

@aheejin aheejin merged commit 10d8b6d into emscripten-core:main Jul 4, 2026
39 checks passed
@aheejin aheejin deleted the update_refactor branch July 4, 2026 06:16
aheejin added a commit to aheejin/emscripten that referenced this pull request Jul 4, 2026
- This checks the that Emscripten directory is clean (has no uncommitted
  changes) before copying its contents. You can force updating with
  `-f`/`--force`.
- This automatically updates version numbers in `readme.txt`.

Suggested in
emscripten-core#27252 (comment).
aheejin added a commit to aheejin/emscripten that referenced this pull request Jul 4, 2026
- This checks the that Emscripten directory is clean (has no uncommitted
  changes) before copying its contents. You can force updating with
  `-f`/`--force`.
- This automatically updates version numbers in `readme.txt`.

Suggested in
emscripten-core#27252 (comment).
aheejin added a commit to aheejin/emscripten that referenced this pull request Jul 4, 2026
- This checks the that Emscripten directory is clean (has no uncommitted
  changes) before copying its contents. You can force updating with
  `-f`/`--force`.
- This automatically updates version numbers in `readme.txt`.

Suggested in
emscripten-core#27252 (comment).
@aheejin

aheejin commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

Another couple of features I though we could add to these scripts:

  1. Confirm the that the source directory is clean (no changes) before copying its contents
  2. Automatically update the readme with the commit/branch we are syncing too?

Tried in #27254.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants